Skip to content

Commit 1be747b

Browse files
Merge pull request #433 from owencompher/main
fix Discord prompt parameter
2 parents d51d115 + b4da2eb commit 1be747b

File tree

2 files changed

+21
-3
lines changed

2 files changed

+21
-3
lines changed

flask_dance/contrib/discord.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ def make_discord_blueprint(
5858
scope = scope or ["identify"]
5959
authorization_url_params = {"prompt": "consent"}
6060
if prompt is None:
61-
authorization_url_params["prompt"] = None
61+
authorization_url_params["prompt"] = "none"
6262
discord_bp = OAuth2ConsumerBlueprint(
6363
"discord",
6464
__name__,

tests/contrib/test_discord.py

Lines changed: 20 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,25 @@ def test_blueprint_factory():
3939
assert discord_bp.authorization_url_params["prompt"] == "consent"
4040

4141

42-
def test_blueprint_factory_with_prompt():
42+
def test_blueprint_factory_with_prompt_consent():
43+
discord_bp = make_discord_blueprint(
44+
client_id="foo",
45+
client_secret="bar",
46+
scope=["identify", "email"],
47+
redirect_to="index",
48+
prompt="consent",
49+
)
50+
assert isinstance(discord_bp, OAuth2ConsumerBlueprint)
51+
assert discord_bp.session.scope == ["identify", "email"]
52+
assert discord_bp.session.base_url == "https://discord.com/"
53+
assert discord_bp.session.client_id == "foo"
54+
assert discord_bp.client_secret == "bar"
55+
assert discord_bp.authorization_url == "https://discord.com/api/oauth2/authorize"
56+
assert discord_bp.token_url == "https://discord.com/api/oauth2/token"
57+
assert discord_bp.authorization_url_params["prompt"] == "consent"
58+
59+
60+
def test_blueprint_factory_with_prompt_None():
4361
discord_bp = make_discord_blueprint(
4462
client_id="foo",
4563
client_secret="bar",
@@ -54,7 +72,7 @@ def test_blueprint_factory_with_prompt():
5472
assert discord_bp.client_secret == "bar"
5573
assert discord_bp.authorization_url == "https://discord.com/api/oauth2/authorize"
5674
assert discord_bp.token_url == "https://discord.com/api/oauth2/token"
57-
assert discord_bp.authorization_url_params["prompt"] == None
75+
assert discord_bp.authorization_url_params["prompt"] == "none"
5876

5977

6078
def test_load_from_config(make_app):

0 commit comments

Comments
 (0)