Skip to content

Improve Attribute View Layout #15178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Improve Attribute View Layout #15178

wants to merge 3 commits into from

Conversation

TCOTC
Copy link
Contributor

@TCOTC TCOTC commented Jun 29, 2025

@@ -104,6 +101,7 @@
&:empty::after {
color: var(--b3-theme-on-surface-light);
content: attr(data-tip);
pointer-events: none;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

伪元素影响了光标样式

image

@@ -400,7 +400,7 @@
&:empty::after {
content: attr(data-tip);
color: var(--b3-theme-on-surface-light);
cursor: text;
pointer-events: none;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

跟前面伪元素影响光标样式的问题使用一致的解决方法

@@ -380,16 +379,15 @@
transition: background 100ms ease-out;
white-space: nowrap;
font-size: 85%;
min-height: 23px;
padding: 5px 4px;
padding: 10px 5px;
Copy link
Contributor Author

@TCOTC TCOTC Jun 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

之前的边距太窄了,有点难看,参考 Notion 把整体边距改到 10px

}

.av__cellassetimg {
margin: 3px 6px 3px 0;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

解决 单选、多选、资源字段 的边距问题

Vanessa219 added a commit that referenced this pull request Jun 30, 2025
@TCOTC
Copy link
Contributor Author

TCOTC commented Jun 30, 2025

3f65251

试了一下这个新加的逻辑不能解决问题

我的这个方法应该是 ok 的了:6e7c862 (#15178)

@Vanessa219
Copy link
Member

这样算解决没?我理解的是 box-shadow 提前消失的问题
https://github.com/user-attachments/assets/c3630723-9c49-4198-8ae7-c154152bb77b

@TCOTC
Copy link
Contributor Author

TCOTC commented Jul 1, 2025

不只是 box-shadow 的问题,前面 #15178 (comment) 我提到了两个问题

我改成用 .av__container.fn__block { overflow: visible; } 应该是能完美解决的了

@Vanessa219
Copy link
Member

Vanessa219 commented Jul 1, 2025

哦,我修改的是切换时两侧的 box-shadow 会消失这个问题。你这个是可以的,这 pr 内容比较多,我先修改这个点。

Vanessa219 added a commit that referenced this pull request Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants