Skip to content

Commit 733fb25

Browse files
committed
remove second loop in the EVM settleOrders implementation
1 parent c4f4103 commit 733fb25

File tree

1 file changed

+0
-13
lines changed

1 file changed

+0
-13
lines changed

solidity/src/FastTransferGateway.sol

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -416,19 +416,6 @@ contract FastTransferGateway is Initializable, UUPSUpgradeable, OwnableUpgradeab
416416
);
417417

418418
amountToRepay += orderSettlementDetails.amount;
419-
}
420-
421-
// effects
422-
for (uint256 pos = 0; pos < orderIDs.length; pos += 32) {
423-
bytes32 orderID;
424-
assembly {
425-
orderID := mload(add(orderIDs, add(0x20, pos)))
426-
}
427-
428-
if (orderStatuses[orderID] != OrderStatus.UNFILLED) {
429-
emit OrderAlreadySettled(orderID);
430-
continue;
431-
}
432419

433420
orderStatuses[orderID] = OrderStatus.FILLED;
434421
emit OrderSettled(orderID);

0 commit comments

Comments
 (0)