Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extreme lag on android #3

Open
J05HI opened this issue Aug 6, 2024 · 9 comments
Open

Extreme lag on android #3

J05HI opened this issue Aug 6, 2024 · 9 comments

Comments

@J05HI
Copy link

J05HI commented Aug 6, 2024

The android debug build is lagging extremely. Take a look at the recording:
https://github.com/user-attachments/assets/a64fac82-1cb9-4769-bef5-bd09597fc1ba

The release build can't be installed:
Screenshot_20240806-183920.png

@aabewhite
Copy link
Contributor

Thanks for the heads-up! To help us investigate: what device/emulator are you using? And is there any chance it's super low on disk space?

@aabewhite
Copy link
Contributor

Also do you see any improvement in scrolling the city list when you hit the button in the upper right to switch to "poster" view mode?

@J05HI
Copy link
Author

J05HI commented Aug 6, 2024

Thanks for the heads-up! To help us investigate: what device/emulator are you using? And is there any chance it's super low on disk space?

I'm on a Pixel 7 Pro, no emulator.
I have about 50 GB free space.

@J05HI
Copy link
Author

J05HI commented Aug 6, 2024

Also do you see any improvement in scrolling the city list when you hit the button in the upper right to switch to "poster" view mode?

A little bit. But not really.

@J05HI
Copy link
Author

J05HI commented Aug 6, 2024

Why can't I install the release build?
Is it corrupted?

@marcprux
Copy link
Contributor

marcprux commented Aug 6, 2024

Why can't I install the release build? Is it corrupted?

The problem with the release build is likely that it is unsigned. The debug build is signed, but with a key that (likely) changes every time, so you wouldn't be able to update the app. If you want to try with the release build, you could download the apk locally and manually sign it, and/or just build the skipapp-bookings app yourself from Xcode with the Release configuration (in which case it would sign it with a temporary key).

@J05HI
Copy link
Author

J05HI commented Aug 7, 2024

Why can't I install the release build? Is it corrupted?

The problem with the release build is likely that it is unsigned. The debug build is signed, but with a key that (likely) changes every time, so you wouldn't be able to update the app. If you want to try with the release build, you could download the apk locally and manually sign it, and/or just build the skipapp-bookings app yourself from Xcode with the Release configuration (in which case it would sign it with a temporary key).

I just signed the release build. Sadly it has the same lag.
The showcase app installed through PlayStore works smoothly.
Have you tested it on an android phone or only simulator?

@J05HI
Copy link
Author

J05HI commented Aug 12, 2024

@aabewhite @marcprux
Any news for the lag problem?

@aabewhite
Copy link
Contributor

Tha is for following up. We isolated and fixed one source of slowdown (SwiftUI's implicit localization of Text). We'll continue to investigate and improve things over time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants