Skip to content

Commit 9677a0d

Browse files
authored
Return Avro objects if implemented instead of String to make producers working with Schema Registry (#34)
## Description Current implementation returns only String which cannot work with Schema Registry. This PR returns Object that allows producers to make it working with Avro. ## Type of Change * Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas Signed-off-by: Jakub Stejskal <[email protected]>
1 parent 8fcc42d commit 9677a0d

File tree

7 files changed

+20
-20
lines changed

7 files changed

+20
-20
lines changed

src/main/java/io/skodjob/datagenerator/DataGenerator.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ public DataGenerator(ETemplateType templateType) {
4141
*
4242
* @return the generated string data
4343
*/
44-
public String generateData() {
44+
public Object generateData() {
4545
switch (this.templateType) {
4646
case PAYROLL:
4747
return PayrollHandler.generateData();
@@ -67,7 +67,7 @@ public String generateData() {
6767
*/
6868
public JsonNode generateJsonData() {
6969
try {
70-
return new ObjectMapper().readTree(generateData());
70+
return new ObjectMapper().readTree(generateData().toString());
7171
} catch (Exception e) {
7272
throw new RuntimeException("Error generating JSON data", e);
7373
}

src/main/java/io/skodjob/datagenerator/handlers/FlightsHandler.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,9 @@ private FlightsHandler() {
3434
/**
3535
* Generates flight data using the Faker library.
3636
*
37-
* @return the generated flight data as a JSON string
37+
* @return the generated flight data as an Avro Object
3838
*/
39-
public static String generateData() {
39+
public static Object generateData() {
4040
FlightRecord flightRecord = new FlightRecord();
4141

4242
Passenger passenger = new Passenger();
@@ -62,6 +62,6 @@ public static String generateData() {
6262
flightRecord.setPassenger(passenger);
6363
flightRecord.setFlight(flight);
6464

65-
return flightRecord.toString();
65+
return flightRecord;
6666
}
6767
}

src/main/java/io/skodjob/datagenerator/handlers/IotDeviceHandler.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -81,9 +81,9 @@ private static String generateActivityState() {
8181
/**
8282
* Generates IoT device data using the Faker library.
8383
*
84-
* @return the generated IoT device data as a JSON string
84+
* @return the generated IoT device data as an Avro Object
8585
*/
86-
public static String generateData() {
86+
public static Object generateData() {
8787
IotDevice iotDevice = new IotDevice();
8888

8989
iotDevice.setIPV4(FAKER.internet().ipV4Address());
@@ -148,6 +148,6 @@ public static String generateData() {
148148
break;
149149
}
150150

151-
return iotDevice.toString();
151+
return iotDevice;
152152
}
153153
}

src/main/java/io/skodjob/datagenerator/handlers/PaymentFiatHandler.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -150,11 +150,11 @@ private static PaymentFiat generatePaymentFiatData() {
150150
/**
151151
* Generates payment data using the Faker library.
152152
*
153-
* @return the generated payment data as a JSON string
153+
* @return the generated payment data as an Avro Object
154154
*/
155-
public static String generateData() {
155+
public static Object generateData() {
156156
PaymentFiat paymentFiat = generatePaymentFiatData();
157157

158-
return paymentFiat.toString();
158+
return paymentFiat;
159159
}
160160
}

src/main/java/io/skodjob/datagenerator/handlers/PayrollHandler.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -29,9 +29,9 @@ private PayrollHandler() {
2929
/**
3030
* Generates payroll employee data using the Faker library.
3131
*
32-
* @return the generated payroll employee data as a JSON string
32+
* @return the generated payroll employee data as an Avro Object
3333
*/
34-
public static String generateData() {
34+
public static Object generateData() {
3535
Employee employee = new Employee();
3636

3737
employee.setEmployeeId(String.valueOf(FAKER.number().numberBetween(10000, 999999)));
@@ -44,6 +44,6 @@ public static String generateData() {
4444
employee.setEmail(FAKER.internet().emailAddress());
4545
employee.setCompany(FAKER.company().name());
4646

47-
return employee.toString();
47+
return employee;
4848
}
4949
}

src/main/java/io/skodjob/datagenerator/handlers/StarGateHandler.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -29,9 +29,9 @@ private StarGateHandler() {
2929
/**
3030
* Generates StarGate data using the Faker library.
3131
*
32-
* @return the generated StarGate data as a JSON string
32+
* @return the generated StarGate data as an Avro Object
3333
*/
34-
public static String generateData() {
34+
public static Object generateData() {
3535
StarGate starGate = new StarGate();
3636
starGate.setCharacterName(FAKER.stargate().characters());
3737
starGate.setSourcePlanet(FAKER.stargate().planets());
@@ -42,6 +42,6 @@ public static String generateData() {
4242
starGate.setDistance(FAKER.number().numberBetween(20000, 999999));
4343
starGate.setDistanceUnit("light_year");
4444

45-
return starGate.toString();
45+
return starGate;
4646
}
4747
}

src/main/java/io/skodjob/datagenerator/handlers/StarWarsHandler.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -29,9 +29,9 @@ private StarWarsHandler() {
2929
/**
3030
* Generates StarWars data using the Faker library.
3131
*
32-
* @return the generated StarWars data as a JSON string
32+
* @return the generated StarWars data as an Avro Object
3333
*/
34-
public static String generateData() {
34+
public static Object generateData() {
3535
StarWars starWars = new StarWars();
3636
starWars.setCharacterName(FAKER.starWars().character());
3737
starWars.setSourcePlanet(FAKER.starWars().planets());
@@ -43,6 +43,6 @@ public static String generateData() {
4343
starWars.setWookieWords(FAKER.starWars().wookieWords());
4444
starWars.setAlternateCharacterSpelling(FAKER.starWars().alternateCharacterSpelling());
4545

46-
return starWars.toString();
46+
return starWars;
4747
}
4848
}

0 commit comments

Comments
 (0)