Skip to content

[ENH] refactoring varying integration test parameters to v1 test framework #1862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fkiraly opened this issue May 30, 2025 · 1 comment
Open
Labels
enhancement New feature or request

Comments

@fkiraly
Copy link
Collaborator

fkiraly commented May 30, 2025

For the purpose of the v1 testing framework, the varying parameters in estimator specific tests should be moved to the get_test_train_params method of the metadata classes.

For this, we should check:

  • in the _integration fixtures, which variables vary
  • ensure these are transferred to get_test_train_params as explicit dict keys - for all algorithms - so the TestAllEstimators run agrees 1:1 with the individual _integration runs

Parameters identified so far that are not explicitly in kwargs of all fixtures:

  • learning_rate (in from_dataset call), this varies across networks
  • cell_type, n_plotting_samples (in from_dataset call) from DeepAR
  • backcast_loss_ratio (in from_dataset call) from NBeats
@fkiraly fkiraly added the enhancement New feature or request label May 30, 2025
@fkiraly
Copy link
Collaborator Author

fkiraly commented May 30, 2025

FYI @phoeenniixx, @PranavBhatP, @fnhirwa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant