[Jobs] Limit number of concurrent jobs & launches. #4248
+60
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Michaelvll
reviewed
Nov 5, 2024
Comment on lines
+490
to
+494
| if (len(managed_job_state.get_nonterminal_job_ids_by_name(None)) > | ||
| managed_job_utils.NUM_JOBS_THRESHOLD): | ||
| raise exceptions.ManagedJobUserCancelledError( | ||
| 'Too many concurrent managed jobs are running. ' | ||
| 'Please try again later or cancel some jobs.') |
There was a problem hiding this comment.
Hmm, this does not make sense, as users should expect the managed jobs being submitted queued on the controller when there is not enough resources on controller, instead of erroring out. Should we instead changing the task CPU requirement based on the memory on controller?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4243.
This PR adds memory limitations for the number of concurrently running jobs, and CPU limitations for the number of concurrent
sky launchby the jobs controller.I followed SkyServe's implementation to only apply CPU limit to concurrent launches, as IIRC
sky.launchconsumes more compute than memory. Also, only apply memory limits to the number of concurrent jobs as ray jobs consume more memory.Tested (run the relevant ones):
bash format.shpytest tests/test_smoke.pypytest tests/test_smoke.py::test_fill_in_the_nameconda deactivate; bash -i tests/backward_compatibility_tests.sh