Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Strip protocol from domains in outgoingDomains of app manifest if present #245

Closed
filmaj opened this issue Nov 15, 2023 · 1 comment · May be fixed by #246
Closed

[FEATURE] Strip protocol from domains in outgoingDomains of app manifest if present #245

filmaj opened this issue Nov 15, 2023 · 1 comment · May be fixed by #246
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@filmaj
Copy link
Contributor

filmaj commented Nov 15, 2023

If you include e.g. https://slack.com in your app manifest's outgoingDomains, you will get an obtuse error like this when trying to run or deploy your app:

Screenshot 2023-11-15 at 3 54 57 PM

Instead, can the SDK detect/remove/strip the protocol and feed the manifest API only the domain that it needs? Could probably use the URL parsing native to deno to do that?
@filmaj filmaj added good first issue Good for newcomers help wanted Extra attention is needed labels Nov 15, 2023
@arunsathiya arunsathiya mentioned this issue Nov 20, 2023
Open
3 tasks
@filmaj filmaj mentioned this issue Sep 5, 2024
Open
@filmaj
Copy link
Contributor Author

filmaj commented Sep 5, 2024

This issue is being tracked over here: slackapi/deno-slack-hooks#95

@filmaj filmaj closed this as completed Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
1 participant
@filmaj