Skip to content

Commit 0408380

Browse files
committed
Import "Keychain" via Swift Package Manager instead of git submodule
1 parent c666285 commit 0408380

File tree

10 files changed

+148
-55
lines changed

10 files changed

+148
-55
lines changed

.github/workflows/build.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,10 @@ jobs:
1717
swift: ['swift6', 'swift5']
1818
include:
1919
- swift: 'swift6'
20-
xcode-path: '/Applications/Xcode_16.0.0.app'
20+
xcode-path: '/Applications/Xcode_16.2.app'
2121
macos: 'macos-14'
2222
- swift: 'swift5'
23-
xcode-path: '/Applications/Xcode_15.4.0.app'
23+
xcode-path: '/Applications/Xcode_15.4.app'
2424
macos: 'macos-14'
2525

2626
env:

.gitmodules

Lines changed: 0 additions & 3 deletions
This file was deleted.

OAuth2.xcodeproj/project.pbxproj

Lines changed: 108 additions & 35 deletions
Large diffs are not rendered by default.

OAuth2.xcworkspace/xcshareddata/swiftpm/Package.resolved

Lines changed: 15 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Package.resolved

Lines changed: 16 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Package.swift

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// swift-tools-version:5.3
1+
// swift-tools-version: 5.5
22
//
33
// Package.swift
44
// OAuth2
@@ -30,14 +30,12 @@ let package = Package(
3030
.library(name: "OAuth2", targets: ["OAuth2"]),
3131
],
3232
dependencies: [
33-
// SwiftKeychain is not yet available as a Package, so we symlink to /Sources and make it a Target
34-
//.package(url: "https://github.com/yankodimitrov/SwiftKeychain.git", majorVersion: 1),
33+
.package(url: "https://github.com/slidoapp/SwiftKeychain.git", branch: "master"),
3534
],
3635
targets: [
3736
.target(name: "OAuth2",
3837
dependencies: ["Base", "Flows", "DataLoader"]),
39-
.target(name: "SwiftKeychain"),
40-
.target(name: "Base", dependencies: [.target(name: "SwiftKeychain")]),
38+
.target(name: "Base", dependencies: ["SwiftKeychain"]),
4139
.target(name: "macOS", dependencies: [.target(name: "Base")]),
4240
.target(name: "iOS", dependencies: [.target(name: "Base")]),
4341
.target(name: "tvOS", dependencies: [.target(name: "Base")]),

Sources/Base/OAuth2KeychainAccount.swift

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -19,17 +19,13 @@
1919
//
2020

2121
import Foundation
22-
#if !NO_KEYCHAIN_IMPORT // needs to be imported when using `swift build`, not when building via Xcode
23-
@preconcurrency import SwiftKeychain
24-
#endif
25-
22+
import SwiftKeychain
2623

2724
/**
2825
Keychain integration handler for OAuth2.
2926
*/
3027
@OAuth2Actor
3128
struct OAuth2KeychainAccount: KeychainGenericPasswordType {
32-
3329
/// The service name to use.
3430
let serviceName: String
3531

@@ -40,7 +36,7 @@ struct OAuth2KeychainAccount: KeychainGenericPasswordType {
4036
var accessGroup: String?
4137

4238
/// Data that ends up in the keychain.
43-
var data = [String: Any]()
39+
var data = KeychainData()
4440

4541
/// Keychain access mode.
4642
let accessMode: String
@@ -66,7 +62,7 @@ struct OAuth2KeychainAccount: KeychainGenericPasswordType {
6662
extension KeychainGenericPasswordType {
6763

6864
/// Data to store to the keychain.
69-
var dataToStore: [String: Any] {
65+
var dataToStore: KeychainData {
7066
return data
7167
}
7268

Sources/SwiftKeychain/Keychain.swift

Lines changed: 0 additions & 1 deletion
This file was deleted.

SwiftKeychain

Lines changed: 0 additions & 1 deletion
This file was deleted.

p2.OAuth2.podspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ Pod::Spec.new do |s|
3838
s.osx.deployment_target = '10.15'
3939
s.tvos.deployment_target = '12.0'
4040
s.pod_target_xcconfig = {
41-
'OTHER_SWIFT_FLAGS' => '-DNO_MODULE_IMPORT -DNO_KEYCHAIN_IMPORT'
41+
'OTHER_SWIFT_FLAGS' => '-DNO_MODULE_IMPORT'
4242
}
4343

4444
s.source_files = [

0 commit comments

Comments
 (0)