Skip to content

Outdated comment in KafkaLatestCommit class #3203

@carlossouzal

Description

@carlossouzal

Hello,

This is not a critical issue, but I believe the comment in the KafkaLatestCommit class might be outdated or incorrect.

Currently, it says:

/**

  • Will commit the record offset received by the Kafka consumer (if higher than the previously committed offset).
  • This offset may be greater than the currently ACKed message.
  • This handler is the default when 'enable.auto.commit' is 'false'.
  • This strategy provides at-least-once delivery if the channel processes the message without performing
  • any asynchronous processing.
  • This strategy should not be used on high-load as offset commit is expensive.
  • To use set 'commit-strategy' to 'latest'.
    */
    public class KafkaLatestCommit extends ContextHolder implements KafkaCommitHandler { ... }

However, based on the implementation in KafkaSource, the default handler when enable.auto.commit is false seems to be THROTTLED:

String commitStrategy = config .getCommitStrategy() .orElse(Boolean.parseBoolean(client.get(ConsumerConfig.ENABLE_AUTO_COMMIT_CONFIG)) ? KafkaCommitHandler.Strategy.IGNORE : KafkaCommitHandler.Strategy.THROTTLED);

It’s not an important functional issue, but I wanted to point it out in case the comment needs to be updated for clarity.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions