Skip to content

Marge Bot is logging PAT while fetching the repository #357

@Sayrus

Description

@Sayrus

While investigating #356, I've stumbled upon logs from marge-bot:

2022-11-03 15:34:03,871 WARNING stderr: b"Cloning into '/tmpmpkpi0fl/tmpcefl0htl'...\nfatal: unable to access 'https://oauth2:[email protected]/repo.git/': SSL certificate problem: certificate has expired\n"

While the log is coming from the Git subprocess, the raw is forwarded to stderr due to how the subprocess pipes are configured. Is this the intended behavior?

This also happens on success as INFO logs pushed directly by marge-bot:

2022-11-10 14:53:17,436 INFO Running git clone --origin=origin https://oauth2:[email protected]/repo.git  /tmpnbm4i1nu/tmptcybhz__

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions