Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add caching to aggregator responses #132

Open
vlad-ignatov opened this issue Oct 24, 2024 · 0 comments
Open

Add caching to aggregator responses #132

vlad-ignatov opened this issue Oct 24, 2024 · 0 comments

Comments

@vlad-ignatov
Copy link
Contributor

There are multiple caching strategies we can try. I'd propose we start with the simplest, which could look like this:

  1. You get the modification date of the underlying s3 file
  2. Make sure you send that date in a Last-Modified header
  3. You may also get a if-modified-since header. If so, compare and:
    • Last-Modified > if-modified-since - exit with 304 status code without doing anything else.
    • Last-Modified <= if-modified-since - Continue with the queries as usual

Notes:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant