Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

technical debt: re-evaluate block skips in unit tests. #71

Open
dogversioning opened this issue Apr 13, 2023 · 0 comments
Open

technical debt: re-evaluate block skips in unit tests. #71

dogversioning opened this issue Apr 13, 2023 · 0 comments

Comments

@dogversioning
Copy link
Contributor

This pattern has gotten bigger and has started to show up in more places in unit tests:

            assert (
                item["Key"].startswith(BucketPath.LAST_VALID.value)
                or item["Key"].startswith(BucketPath.ARCHIVE.value)
                or item["Key"].startswith(BucketPath.ERROR.value)
                or item["Key"].startswith(BucketPath.ADMIN.value)
                or item["Key"].endswith("study_periods.json")
            )

This should be re-evaluated - this is :mostly: due to the shared S3 mock and isn't delivering a lot of value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants