Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand s3 tests #81

Open
mikix opened this issue Nov 17, 2022 · 0 comments
Open

Expand s3 tests #81

mikix opened this issue Nov 17, 2022 · 0 comments
Labels
good first issue Good for newcomers

Comments

@mikix
Copy link
Contributor

mikix commented Nov 17, 2022

The S3 testing we have is a little light, for such a common production endpoint. Ideally we'd have some stuff that tested:

  • The s3 command line options (s3-region and s3-kms-key) getting through to the other side
  • That the data we write is actually correct (I think we just check that the filenames are good right now, in test_etl.py)
@mikix mikix added the good first issue Good for newcomers label Nov 17, 2022
@mikix mikix changed the title Expand bulk/s3 tests Expand s3 tests Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant