Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Routes like /patient/:index aren't stable when dataset changes #7

Open
the-kenny opened this issue Feb 13, 2020 · 0 comments
Open

Routes like /patient/:index aren't stable when dataset changes #7

the-kenny opened this issue Feb 13, 2020 · 0 comments

Comments

@the-kenny
Copy link

the-kenny commented Feb 13, 2020

Hello,

I'm playing around with the demo and looking at the implementation. One thing I've notices is that you're using index-based URLs to display patient-details. This is problematic when the underlying dataset changes.

  1. I search for "von" and click on the third patient in the result
  2. I get redirected to /patient/2
  3. Another Patient with "von" in its name is added
  4. At some later point, I reload the page. I may or may not see a different patient's details because the new patient may or may appear in the search results before the patient I was originally looking at.

A solution would be changing your routing to link to /patient/:id where :id is Patient.id.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant