Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Location should not be a standard launch context parameter #131

Open
isaacvetter opened this issue Mar 22, 2017 · 2 comments
Open

Location should not be a standard launch context parameter #131

isaacvetter opened this issue Mar 22, 2017 · 2 comments
Labels
into-hl7

Comments

@isaacvetter
Copy link
Member

isaacvetter commented Mar 22, 2017 •
edited
Loading

Location should not be a standard launch context parameter because a clinical location in which the app is being used already exists in the Encounter resource's class and Location elements.

Additionally, very few and perhaps no production FHIR server support Location yet. I think that no one has actually implemented a launch parameter specifying to specify a FHIR Location resource (unlike Patient and Encounter).

Pull request #132
@kpshek
Copy link
Contributor

kpshek commented Apr 17, 2017

👍

Specially, we should remove:

  • The launch/location scope
  • The location launch context parameter

@jmandel
Copy link
Member

jmandel commented Apr 18, 2017

+1

Also noting: #133 address another use case that some have expressed for location: the ability to tell "whom to charge" for a given app launch.

@kpshek kpshek mentioned this issue Apr 18, 2017
Closed
isaacvetter added a commit to isaacvetter/smart-on-fhir.github.io that referenced this issue Jul 26, 2017
@isaacvetter
Remove Location from list of SMART launch parameters
ea82b28 
Fixes smart-on-fhir#131

Note that I removed documentation of both the launch param and the
launch/location scope. The spec already enables launch scopes and
corresponding launch params to be extended if required.
isaacvetter added a commit to tmp-smart-into-hl7/smart-on-fhir.github.io that referenced this issue Jul 26, 2017
@isaacvetter
Remove location launch scope and launch param
fd57b40 
Fixes smart-on-fhir#131

Remove location from both launch scope and launch parameter. Note that
spec already accounts for extending launch scopes/params if required.
@isaacvetter isaacvetter mentioned this issue Jul 26, 2017
Open
This was referenced Dec 21, 2017
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
into-hl7
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@isaacvetter @kpshek @jmandel