llo: switch to github.com/goccy/go-json to improve performance of encode/decode ops (#188)

brunotm · web-flow · commit 3f1e8da5307a · 2025-10-01T17:09:15.000+02:00
* llo: switch to github.com/goccy/go-json to improve performance of encode/decode ops
diff --git a/go.mod b/go.mod
@@ -7,6 +7,7 @@ toolchain go1.24.4
 require (
 	github.com/ethereum/go-ethereum v1.15.3
 	github.com/expr-lang/expr v1.17.5
+	github.com/goccy/go-json v0.10.4
 	github.com/hashicorp/go-plugin v1.6.3
 	github.com/klauspost/compress v1.18.0
 	github.com/leanovate/gopter v0.2.11
diff --git a/go.sum b/go.sum
@@ -558,10 +558,6 @@ github.com/shurcooL/vfsgen v0.0.0-20200824052919-0d455de96546/go.mod h1:TrYk7fJV
 github.com/sirupsen/logrus v1.4.1/go.mod h1:ni0Sbl8bgC9z8RoU9G6nDWqqs/fq4eDPysMBDgk/93Q=
 github.com/sirupsen/logrus v1.4.2/go.mod h1:tLMulIdttU9McNUspp0xgXVQah82FyeX6MwdIuYE2rE=
 github.com/sirupsen/logrus v1.8.1/go.mod h1:yWOB1SBYBC5VeMP7gHvWumXLIWorT60ONWic61uBYv0=
-github.com/smartcontractkit/chainlink-common v0.7.1-0.20250612160538-bf4097d092cb h1:jDoqH/5lFEAscgc6yUYg1SzthHct98z5nUwmuSN5Pq4=
-github.com/smartcontractkit/chainlink-common v0.7.1-0.20250612160538-bf4097d092cb/go.mod h1:H7gOuN4Jzf+DWllfP5Pb7AiCWBMQrDX1D1KYXAEhdnw=
-github.com/smartcontractkit/chainlink-common v0.7.1-0.20250620171839-6009cad95977 h1:7Rn14H77o9OmnsWU75FWkJjQ6JXvTBSu7vGWQ3D+Nrg=
-github.com/smartcontractkit/chainlink-common v0.7.1-0.20250620171839-6009cad95977/go.mod h1:crejZI9ZpBHfhqghQOG9u7Sri7CBzEUYQ/0lVnN60yg=
 github.com/smartcontractkit/chainlink-common v0.7.1-0.20250623140116-9cb7ec4a4def h1:83rS5GM53zm0G8eIfTtxBK5o8YRZf5bDoku98E/noks=
 github.com/smartcontractkit/chainlink-common v0.7.1-0.20250623140116-9cb7ec4a4def/go.mod h1:crejZI9ZpBHfhqghQOG9u7Sri7CBzEUYQ/0lVnN60yg=
 github.com/smartcontractkit/freeport v0.1.1 h1:B5fhEtmgomdIhw03uPVbVTP6oPv27fBhZsoZZMSIS8I=
diff --git a/llo/json_report_codec.go b/llo/json_report_codec.go
@@ -2,10 +2,11 @@ package llo
 
 import (
 	"encoding/hex"
-	"encoding/json"
 	"errors"
 	"fmt"
 
+	"github.com/goccy/go-json"
+
 	"github.com/smartcontractkit/libocr/offchainreporting2/types"
 	ocr2types "github.com/smartcontractkit/libocr/offchainreporting2/types"
 
diff --git a/llo/json_report_codec_test.go b/llo/json_report_codec_test.go
@@ -325,7 +325,8 @@ func Test_JSONCodec(t *testing.T) {
 			cdc := JSONReportCodec{}
 
 			_, err := cdc.Pack(digest, seqNr, report, sigs)
-			require.EqualError(t, err, "json: error calling MarshalJSON for type json.RawMessage: invalid character 'o' in literal false (expecting 'a')")
+			require.Error(t, err)
+			require.Contains(t, err.Error(), "json: error calling MarshalJSON for type json.RawMessage")
 		})
 		t.Run("report is valid JSON", func(t *testing.T) {
 			digest := types.ConfigDigest([32]byte{1, 2, 3})
diff --git a/llo/reportcodecs/evm/report_codec_common.go b/llo/reportcodecs/evm/report_codec_common.go
@@ -1,13 +1,14 @@
 package evm
 
 import (
-	"encoding/json"
 	"fmt"
 	"math"
 	"math/big"
 	"regexp"
 	"strconv"
 
+	"github.com/goccy/go-json"
+
 	"github.com/shopspring/decimal"
 
 	llotypes "github.com/smartcontractkit/chainlink-common/pkg/types/llo"
diff --git a/llo/reportcodecs/evm/report_codec_common_test.go b/llo/reportcodecs/evm/report_codec_common_test.go
@@ -2,12 +2,13 @@ package evm
 
 import (
 	"encoding/hex"
-	"encoding/json"
 	"fmt"
 	"math"
 	"math/big"
 	"testing"
 
+	"github.com/goccy/go-json"
+
 	"github.com/shopspring/decimal"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
diff --git a/llo/reportcodecs/evm/report_codec_evm_abi_encode_unpacked.go b/llo/reportcodecs/evm/report_codec_evm_abi_encode_unpacked.go
@@ -2,11 +2,12 @@ package evm
 
 import (
 	"bytes"
-	"encoding/json"
 	"errors"
 	"fmt"
 	"math/big"
 
+	"github.com/goccy/go-json"
+
 	"github.com/ethereum/go-ethereum/accounts/abi"
 	"github.com/ethereum/go-ethereum/common"
 	"github.com/shopspring/decimal"
diff --git a/llo/reportcodecs/evm/report_codec_evm_abi_encode_unpacked_expr_test.go b/llo/reportcodecs/evm/report_codec_evm_abi_encode_unpacked_expr_test.go
@@ -201,7 +201,7 @@ func TestReportCodecEVMABIEncodeUnpackedExpr_Verify(t *testing.T) {
 		}
 		err := c.Verify(cd)
 		require.Error(t, err)
-		require.EqualError(t, err, "invalid Opts, got: \"\\\"invalid\\\"\"; json: cannot unmarshal string into Go value of type evm.ReportFormatEVMABIEncodeOpts")
+		require.Contains(t, err.Error(), "invalid character")
 	})
 	t.Run("negative BaseUSDFee", func(t *testing.T) {
 		cd := llotypes.ChannelDefinition{
diff --git a/llo/reportcodecs/evm/report_codec_evm_abi_encode_unpacked_test.go b/llo/reportcodecs/evm/report_codec_evm_abi_encode_unpacked_test.go
@@ -704,7 +704,7 @@ func TestReportCodecEVMABIEncodeUnpacked_Verify(t *testing.T) {
 		}
 		err := c.Verify(cd)
 		require.Error(t, err)
-		require.EqualError(t, err, "invalid Opts, got: \"\\\"invalid\\\"\"; json: cannot unmarshal string into Go value of type evm.ReportFormatEVMABIEncodeOpts")
+		require.Contains(t, err.Error(), "invalid Opts, got: \"\\\"invalid\\\"\"")
 	})
 	t.Run("negative BaseUSDFee", func(t *testing.T) {
 		cd := llotypes.ChannelDefinition{
diff --git a/llo/reportcodecs/evm/report_codec_evm_streamlined.go b/llo/reportcodecs/evm/report_codec_evm_streamlined.go
@@ -3,10 +3,11 @@ package evm
 import (
 	"bytes"
 	"encoding/binary"
-	"encoding/json"
 	"fmt"
 	"math"
 
+	"github.com/goccy/go-json"
+
 	"github.com/ethereum/go-ethereum/common"
 	"github.com/smartcontractkit/libocr/offchainreporting2/types"
 	"google.golang.org/protobuf/proto"
diff --git a/llo/reportcodecs/evm/report_codec_evm_streamlined_test.go b/llo/reportcodecs/evm/report_codec_evm_streamlined_test.go
@@ -94,7 +94,8 @@ func TestReportCodecEVMStreamlined(t *testing.T) {
 				err = codec.Verify(llotypes.ChannelDefinition{
 					Opts: []byte(`{"feedID":"0xinvalid","abi":[{"type":"int160"}]}`),
 				})
-				require.EqualError(t, err, "failed to decode opts; got: '{\"feedID\":\"0xinvalid\",\"abi\":[{\"type\":\"int160\"}]}'; json: cannot unmarshal hex string of odd length into Go struct field ReportFormatEVMStreamlinedOpts.feedID of type common.Hash")
+				require.Error(t, err)
+				require.Contains(t, err.Error(), "json: cannot unmarshal hex string of odd length")
 			})
 		})
 	})
diff --git a/llo/reportcodecs/evm/report_codec_premium_legacy.go b/llo/reportcodecs/evm/report_codec_premium_legacy.go
@@ -2,12 +2,13 @@ package evm
 
 import (
 	"bytes"
-	"encoding/json"
 	"errors"
 	"fmt"
 	"math"
 	"math/big"
 
+	"github.com/goccy/go-json"
+
 	"github.com/ethereum/go-ethereum/accounts/abi"
 	"github.com/ethereum/go-ethereum/common"
 	"github.com/shopspring/decimal"
diff --git a/llo/reportcodecs/evm/report_codec_premium_legacy_test.go b/llo/reportcodecs/evm/report_codec_premium_legacy_test.go
@@ -267,7 +267,7 @@ func Test_ReportCodecPremiumLegacy_Verify(t *testing.T) {
 		}
 		err := c.Verify(cd)
 		require.Error(t, err)
-		assert.Contains(t, err.Error(), "invalid Opts, got: \"\\\"invalid\\\"\"; json: cannot unmarshal string into Go value of type evm.ReportFormatEVMPremiumLegacyOpts")
+		assert.Contains(t, err.Error(), "invalid Opts, got: \"\\\"invalid\\\"\"")
 	})
 	t.Run("negative BaseUSDFee", func(t *testing.T) {
 		cd := llotypes.ChannelDefinition{
@@ -303,7 +303,7 @@ func Test_ReportCodecPremiumLegacy_Verify(t *testing.T) {
 		}
 		err := c.Verify(cd)
 		require.Error(t, err)
-		assert.Contains(t, err.Error(), "invalid Opts, got: \"{\\\"baseUSDFee\\\":\\\"1\\\",\\\"feedID\\\":\\\"foo\\\"}\"; json: cannot unmarshal hex string without 0x prefix into Go struct field ReportFormatEVMPremiumLegacyOpts.feedID of type common.Hash")
+		assert.Contains(t, err.Error(), "json: cannot unmarshal hex string without 0x prefix into Go value of type common.Hash")
 	})
 	t.Run("valid", func(t *testing.T) {
 		cd := llotypes.ChannelDefinition{
diff --git a/llo/reportcodecs/evm/utils/big.go b/llo/reportcodecs/evm/utils/big.go
@@ -2,10 +2,11 @@ package utils
 
 import (
 	"database/sql/driver"
-	"encoding/json"
 	"fmt"
 	"math/big"
 
+	"github.com/goccy/go-json"
+
 	"github.com/ethereum/go-ethereum/common/hexutil"
 
 	bigmath "github.com/smartcontractkit/chainlink-common/pkg/utils/big_math"
diff --git a/llo/retirement_report_codec.go b/llo/retirement_report_codec.go
@@ -1,7 +1,7 @@
 package llo
 
 import (
-	"encoding/json"
+	"github.com/goccy/go-json"
 )
 
 type RetirementReportCodec interface {
diff --git a/llo/stream_calculated.go b/llo/stream_calculated.go
@@ -1,7 +1,6 @@
 package llo
 
 import (
-	"encoding/json"
 	"fmt"
 	"math"
 	"math/big"
@@ -10,6 +9,8 @@ import (
 	"sync"
 	"time"
 
+	"github.com/goccy/go-json"
+
 	"github.com/expr-lang/expr"
 	"github.com/expr-lang/expr/ast"
 	"github.com/expr-lang/expr/parser"
diff --git a/llo/stream_value.go b/llo/stream_value.go
@@ -2,11 +2,12 @@ package llo
 
 import (
 	"encoding"
-	"encoding/json"
 	"errors"
 	"fmt"
 	"regexp"
 
+	"github.com/goccy/go-json"
+
 	"google.golang.org/protobuf/proto"
 
 	"github.com/shopspring/decimal"
diff --git a/mercury/offchain_config.go b/mercury/offchain_config.go
@@ -1,9 +1,10 @@
 package mercury
 
 import (
-	"encoding/json"
 	"fmt"
 
+	"github.com/goccy/go-json"
+
 	"github.com/shopspring/decimal"
 )
 

Original file line number	Diff line number	Diff line change
`@@ -201,7 +201,7 @@ func TestReportCodecEVMABIEncodeUnpackedExpr_Verify(t *testing.T) {`
`201`	`201`	`}`
`202`	`202`	`err := c.Verify(cd)`
`203`	`203`	`require.Error(t, err)`
`204`		`- require.EqualError(t, err, "invalid Opts, got: \"\\\"invalid\\\"\"; json: cannot unmarshal string into Go value of type evm.ReportFormatEVMABIEncodeOpts")`
	`204`	`+ require.Contains(t, err.Error(), "invalid character")`
`205`	`205`	`})`
`206`	`206`	`t.Run("negative BaseUSDFee", func(t *testing.T) {`
`207`	`207`	`cd := llotypes.ChannelDefinition{`
Original file line number	Diff line number	Diff line change
`@@ -704,7 +704,7 @@ func TestReportCodecEVMABIEncodeUnpacked_Verify(t *testing.T) {`
`704`	`704`	`}`
`705`	`705`	`err := c.Verify(cd)`
`706`	`706`	`require.Error(t, err)`
`707`		`- require.EqualError(t, err, "invalid Opts, got: \"\\\"invalid\\\"\"; json: cannot unmarshal string into Go value of type evm.ReportFormatEVMABIEncodeOpts")`
	`707`	`+ require.Contains(t, err.Error(), "invalid Opts, got: \"\\\"invalid\\\"\"")`
`708`	`708`	`})`
`709`	`709`	`t.Run("negative BaseUSDFee", func(t *testing.T) {`
`710`	`710`	`cd := llotypes.ChannelDefinition{`