Skip to content

Commit 4431a65

Browse files
authored
update prom suffixes (#2149)
* update prom suffixes * ignore if there is no compose dir on restart * changeset
1 parent cbe9e69 commit 4431a65

File tree

3 files changed

+7
-5
lines changed

3 files changed

+7
-5
lines changed

framework/.changeset/v0.10.28.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
- Unify local obs stack metrics for otel Prom between local and production, remove suffixes

framework/observability.go

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -173,12 +173,10 @@ func ObservabilityUpFull() error {
173173

174174
func ObservabilityDown() error {
175175
L.Info().Msg("Removing local observability stack")
176-
err := RunCommand("bash", "-c", fmt.Sprintf(`
176+
_ = RunCommand("bash", "-c", fmt.Sprintf(`
177177
cd %s && \
178178
docker compose down -v && docker rm -f promtail
179179
`, "compose"))
180-
if err != nil {
181-
return err
182-
}
183-
return RunCommand("bash", "-c", "rm -rf compose/")
180+
_ = RunCommand("bash", "-c", "rm -rf compose/")
181+
return nil
184182
}

framework/observability/compose/otel.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,9 @@ exporters:
2121
insecure: true
2222
prometheus:
2323
endpoint: "0.0.0.0:8889"
24+
resource_to_telemetry_conversion:
25+
enabled: true
26+
add_metric_suffixes: false
2427

2528
processors:
2629
transform:

0 commit comments

Comments
 (0)