Skip to content
This repository has been archived by the owner on Jan 15, 2025. It is now read-only.

Why this is not an Addon? #1

Closed
GeorgeS2019 opened this issue Apr 23, 2021 · 6 comments
Closed

Why this is not an Addon? #1

GeorgeS2019 opened this issue Apr 23, 2021 · 6 comments
Labels
discussion Something to talk about enhancement New feature or request

Comments

@GeorgeS2019
Copy link

@smix8 Can you please share why this is not as Godot Addon?
I have seen other addon register a new Node Type. Is this a performance issue that we are not aware of?

@smix8
Copy link
Owner

smix8 commented Apr 23, 2021

I started out with an addon and the performance was to atrocious to be used at runtime. If you have a long animation with many keyframes and tracks the C++ version can currently create some small stutters but the addon would freeze your entire game for seconds.

After the addon trial and error I created a core implementation first for my own need and later decided to transfer it to a module to make it more shareable.

So the primary reason why this is a module and not an addon is performance but also history.

What I could do in the future would be to provide a downsized addon version that has only baking features for inside the editor.

@GeorgeS2019
Copy link
Author

GeorgeS2019 commented Apr 23, 2021

@smix8 Thanks for sharing, especially offering Proof of Concepts on regular basis what Godot could do in terms of 3D character/humanoid animation!

@smix8
Copy link
Owner

smix8 commented Apr 23, 2021

Oh Godot can do a lot, sometimes far more or better than other established game engines. Godot and I share the same issue, we are either bad or don't care about marketing.

@GeorgeS2019
Copy link
Author

@smix8 The whole MIT Open Source is key why I work on Godot. Keep advincing. I do the marketing for U :-)

@smix8 smix8 added discussion Something to talk about enhancement New feature or request labels Apr 23, 2021
@smix8
Copy link
Owner

smix8 commented Apr 25, 2021

Fixed by commit 23da6b9

GDScript testversion for Godot 3.x is now available.

Created a new branch for GDScript found here:
https://github.com/smix8/GodotAnimationRetargeting/tree/godot_3.x_gdscript

@smix8 smix8 closed this as completed Apr 25, 2021
@GeorgeS2019
Copy link
Author

@smix8

This is the first I've heard of it. Will take a look!

The developer of BVH import delighted with your project! Good job!!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
discussion Something to talk about enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants