Skip to content

Switch to unconditional no_std attribute #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 28, 2025
Merged

Switch to unconditional no_std attribute #128

merged 1 commit into from
Jun 28, 2025

Conversation

jplatte
Copy link
Contributor

@jplatte jplatte commented Jun 22, 2025

Makes dependencies on std clearer by avoiding the prelude.

We could also convert some std imports to alloc imports now, and maybe some of the std-gated code can actually become alloc-gated.

@jplatte
Switch to unconditional no_std attribute
af92e63 
Makes dependencies on std clearer by avoiding the prelude.
taiki-e
taiki-e approved these changes Jun 28, 2025
View reviewed changes
Copy link
Collaborator

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Previously this was not possible due to MSRV (a28ac5b), but now MSRV supports async/await with no-std, so it does not seem to be a problem.

@taiki-e taiki-e merged commit 077e1c1 into smol-rs:master Jun 28, 2025
7 checks passed
@jplatte jplatte deleted the jplatte/no-std branch June 28, 2025 12:29
@jplatte jplatte mentioned this pull request Jun 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taiki-e taiki-e taiki-e approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jplatte @taiki-e