-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Fixed: escape '/' in preg_quote of asset tag prefix #16542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Signed-off-by: snipe <[email protected]>
Signed-off-by: snipe <[email protected]> # Conflicts: # config/version.php
Signed-off-by: snipe <[email protected]> # Conflicts: # config/version.php
Signed-off-by: snipe <[email protected]>
Signed-off-by: snipe <[email protected]> # Conflicts: # public/css/dist/skins/_all-skins.css # public/css/dist/skins/_all-skins.min.css # public/css/dist/skins/skin-blue.css # public/css/dist/skins/skin-blue.min.css # public/mix-manifest.json
Signed-off-by: snipe <[email protected]> # Conflicts: # config/version.php
Signed-off-by: snipe <[email protected]> # Conflicts: # public/css/build/app.css # public/css/build/overrides.css # public/css/dist/all.css # public/js/build/app.js # public/js/dist/all.js # public/mix-manifest.json
Merge develop into master
Merge grokability#16486 and grokability#16519 into master
When using a prefix with forward slash, preg_quote without arguments fails to escape it and results in error in javascript console while trying for example to create a new asset.
💖 Thanks for this pull request! 💖 We use semantic commit messages to streamline the release process and easily generate changelogs between versions. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix if it doesn't have one already. Examples of commit messages with semantic prefixes:
Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
PR Summary
|
Hi there - thanks for this! Can you please re-target this PR to point to the You usually don't need to close and re-open. After you create a pull request, you can modify the base branch so that the changes in the pull request are compared against a different branch. By changing the base branch of your original pull request rather than opening a new one with the correct base branch, you’ll be able to keep valuable work and discussion. Thanks! |
This resolves the issue I encountered in version 8 of snipe-it (8.0.4)
When using a prefix with forward slash,
preg_quote
without arguments fails to escape it and results in error in Javascript console while trying for example to create a new asset.Here's the original error:
missing after parenthesis Uncaught SyntaxError: missing ) source: create:1303:64
which points to the same line fixed in edit.blade.php