Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1621414: Update fast-xml-parser package to v4.4.1 to Fix ReDOS Vulnerability #885

Closed
GOPIKRISHNA11596 opened this issue Aug 12, 2024 · 1 comment
Assignees
Labels
invalid This doesn't seem right status-triage_done Initial triage done, will be further handled by the driver team

Comments

@GOPIKRISHNA11596
Copy link

What is the current behavior?

Currently Snowflake-SDK using the "fast-xml-parser" version of "^4.2.5", But version below 4.4.1 is having ReDOS vulnerability. GHSA-mpg4-rc92-vx8v

What is the desired behavior?

To fix ReDOS vulnerability, need to update "fast-xml-parser" to "^4.4.1"

How would this improve snowflake-connector-nodejs?

It fixes ReDOS vulnerability

References, Other Background

Please go through link for more info,
Vulnerability : GHSA-mpg4-rc92-vx8v

@github-actions github-actions bot changed the title Update fast-xml-parser package to v4.4.1 to Fix ReDOS Vulnerability SNOW-1621414: Update fast-xml-parser package to v4.4.1 to Fix ReDOS Vulnerability Aug 12, 2024
@sfc-gh-dszmolka sfc-gh-dszmolka self-assigned this Aug 12, 2024
@sfc-gh-dszmolka
Copy link
Collaborator

thank you for keeping a keen eye for vulnerabilities ! fortunately this doesn't affect snowflake-sdk.
requirement of "fast-xml-parser": "^4.2.5", means 'install the latest which is at least 4.2.5, but no greater or equal to 5.0.0' (docs)

so fixed fast-xml-parses is automatically installed when you (re)install snowflake-sdk. simple test:

# npm i snowflake-sdk
..gets installed
# npm list fast-xml-parser
test@ /test
`-- [email protected]
  +-- @aws-sdk/[email protected]
  | `-- @aws-sdk/[email protected]
  |   `-- [email protected] deduped
  +-- @google-cloud/[email protected]
  | `-- [email protected] deduped
  `-- [email protected].  <<<<< this is the fixed version which is installed automatically

closing this issue for now but if you found something different and have evidence that upon install, a vulnerable version of fast-xml-parser is installed, comment here please and i'll look.

@sfc-gh-dszmolka sfc-gh-dszmolka added invalid This doesn't seem right status-triage_done Initial triage done, will be further handled by the driver team labels Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right status-triage_done Initial triage done, will be further handled by the driver team
Projects
None yet
Development

No branches or pull requests

2 participants