Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1789663 package moved to smithy from aws-sdk #950

Merged
merged 4 commits into from
Nov 12, 2024

Conversation

sfc-gh-dszmolka
Copy link
Collaborator

Description

npm WARN deprecated @aws-sdk/[email protected]: This package has moved to @smithy/node-http-handler

upon npm install.

Per aws/aws-sdk-js-v3#5006 this is supposed to be a rename only and existing interfaces should work as-is.

Checklist

  • Format code according to the existing code style (run npm run lint:check -- CHANGED_FILES and fix problems in changed code)
  • Create tests which fail without the change (if possible)
  • Make all tests (unit and integration) pass (npm run test:unit and npm run test:integration)
  • Extend the README / documentation and ensure is properly displayed (if necessary)
  • Provide JIRA issue id (if possible) or GitHub issue id in commit message

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.93%. Comparing base (e04084d) to head (16efaad).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #950      +/-   ##
==========================================
+ Coverage   88.91%   88.93%   +0.01%     
==========================================
  Files          69       69              
  Lines        6685     6685              
==========================================
+ Hits         5944     5945       +1     
+ Misses        741      740       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-dszmolka
Copy link
Collaborator Author

/recheck

@sfc-gh-dszmolka
Copy link
Collaborator Author

For some reason, the Jenkins build was unsuccessful. Before merging this jira, we would need to validate if it's a transient issue, or an issue directly caused from this PR.

@sfc-gh-dszmolka
Copy link
Collaborator Author

all tests green.

@sfc-gh-dszmolka sfc-gh-dszmolka merged commit d50e1ce into master Nov 12, 2024
57 checks passed
@sfc-gh-dszmolka sfc-gh-dszmolka deleted the SNOW-1789663-aws-sdk-to-smithy branch November 12, 2024 12:04
@github-actions github-actions bot locked and limited conversation to collaborators Nov 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants