Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1791788: Browser authentication timeout timer not cleared on successful authentication #953

Closed
adriancooney opened this issue Nov 7, 2024 · 1 comment · May be fixed by #954
Closed
Assignees
Labels
bug Something isn't working duplicate This issue or pull request already exists status-triage_done Initial triage done, will be further handled by the driver team

Comments

@adriancooney
Copy link

If you need urgent assistance then file a case with Snowflake Support.
Otherwise continue here.

Please answer these questions before submitting your issue.
In order to accurately debug the issue this information is required. Thanks!

  1. What version of NodeJS driver are you using?

1.14.0

  1. What operating system and processor architecture are you using?

Operating System: Darwin (macOS)
Kernel Version: 23.6.0
Processor Architecture: ARM64

  1. What version of NodeJS are you using?
    (node --version and npm --version)
$ node -v
v22.5.1
$ pnpm -v
9.5.0
  1. What are the component versions in the environment (npm list)?

  2. What did you do?

  3. Create a connection using createConnection with the authenticator set to EXTERNALBROWSER.

  4. Call connectAsync which opens up browser tab.

  5. Complete authentication flow successfully.

  6. Execute simple query (< 3 seconds).

  7. Close the connection.

  8. Expect program to exit - it does not.

  9. What did you expect to see?

Expect program to exit - it does not.

There is an open timer, created here, preventing the program from exiting. The timer is essentially a timeout for the browser authentication. It should be cleared if the authentication was successful.

  1. Can you collect debug logs?
[WTF Node?] open handles:
- File descriptors: (note: stdio always exists)
  - fd 1 (tty) (stdio)
  - fd 2 (tty) (stdio)
- Timers:
  - (120000 ~ 2 min) (anonymous) @ ./node_modules/.pnpm/[email protected][email protected][email protected][email protected]/node_modules/snowflake-sdk/lib/authentication/auth_web.js:181

⚠️ Before sharing any data, please be sure to review the log and remove any sensitive
information.

@adriancooney adriancooney added the bug Something isn't working label Nov 7, 2024
@github-actions github-actions bot changed the title Browser authentication timeout timer not cleared on successful authentication SNOW-1791788: Browser authentication timeout timer not cleared on successful authentication Nov 7, 2024
@sfc-gh-dszmolka
Copy link
Collaborator

hi - sounds like a duplicate to #846
but thank you for the contribution! i'll close this issue as it doesn't need to exist, since it's a duplicate. However the PR still is useful.

@sfc-gh-dszmolka sfc-gh-dszmolka closed this as not planned Won't fix, can't repro, duplicate, stale Nov 7, 2024
@sfc-gh-dszmolka sfc-gh-dszmolka self-assigned this Nov 7, 2024
@sfc-gh-dszmolka sfc-gh-dszmolka added duplicate This issue or pull request already exists status-triage_done Initial triage done, will be further handled by the driver team labels Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working duplicate This issue or pull request already exists status-triage_done Initial triage done, will be further handled by the driver team
Projects
None yet
2 participants