SNOW-1800528 don't log anything if logLevel is set to OFF
#958
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #957 is was reported that even with
snowflake.configure({ logLevel: OFF });
which is expected to disable logging; a single logline is still logged
at default
INFO
level before setting loglevel to-1
and actually disabling logging.Moving this logline to after the logger has been configured with local loglevel allows for preserve the same information for the ones who need it for tracking purposes, and stop logging it for the ones who wish the driver to not emit logs.
Checklist
npm run lint:check -- CHANGED_FILES
and fix problems in changed code)npm run test:unit
andnpm run test:integration
)