-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-1462014: Ability to disable OTel span creation even if opentelemetry is installed #1730
Comments
Hi, do you just want to be able to disable all snowpark emit spans, or you also want to have control on what function should not emit span? For example, do you want snowpark to emit span on .collect() while not emitting span on .show() ? |
@sfc-gh-yuwang thanks so much for responding! For now I think it's an overall switch-off (@trevor-laviale-arize might be able to chime in here) |
Yeah I think just the ability to disable in general is good for now :) |
Got it, will do this recently, I am thinking about having a environment variable to turn on/off snowpark opentelemetry |
Amazing, thanks so much! |
Thanks @sfc-gh-yuwang - env var makes a ton of sense |
I want to do a quick update on this issue, we are now discussing with other teams who potentially could have the issue about a uniform solution across snowflake, we should have this solved within this month |
@mikeldking , @trevor-laviale-arize -- Have you tried setting this env var? https://opentelemetry.io/docs/zero-code/python/configuration/#disabling-specific-instrumentations |
I also find that opentelemetry has recently added a feature of trace config: open-telemetry/opentelemetry-specification#3877 , can you also try it? |
What is the current behavior?
If opentelemetry is installed, spans are automatically emitted via https://github.com/snowflakedb/snowpark-python/blob/29b3bba9a7bd13206221b6fc6ad9ed0fae853fe0/src/snowflake/snowpark/_internal/open_telemetry.py
What is the desired behavior?
Add the ability to disable span creation even if opentelemetry is installed so as to keep the trace hierarchy simpler.
How would this improve
snowflake-snowpark-python
?Make it more configurable and more composable with other OTel instrumentations
References, Other Background
OTel gives you the ability to turn off different instrumentations like so: https://github.com/snowflakedb/snowpark-python/blob/29b3bba9a7bd13206221b6fc6ad9ed0fae853fe0/src/snowflake/snowpark/_internal/open_telemetry.py
The text was updated successfully, but these errors were encountered: