Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1557539 count describe queries for test #2249

Conversation

sfc-gh-evandenberg
Copy link
Collaborator

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1557539 count describe queries for test

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
  3. Please describe how your code solves the related issue.

Add describe query to query listener history (opt-in)

@sfc-gh-evandenberg sfc-gh-evandenberg force-pushed the evandenberg-SNOW-1557539-count-describe-queries-for-test-2 branch from aaa5882 to 53e512a Compare September 9, 2024 20:54
@sfc-gh-evandenberg sfc-gh-evandenberg added NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs labels Sep 10, 2024
@sfc-gh-evandenberg sfc-gh-evandenberg force-pushed the evandenberg-SNOW-1557539-count-describe-queries-for-test-2 branch from 53e512a to 11fab71 Compare September 10, 2024 23:35
CHANGELOG.md Outdated Show resolved Hide resolved
@sfc-gh-evandenberg sfc-gh-evandenberg force-pushed the evandenberg-SNOW-1557539-count-describe-queries-for-test-2 branch 3 times, most recently from ee48e09 to 18f73f0 Compare September 16, 2024 18:11
@sfc-gh-helmeleegy
Copy link
Contributor

Will we plan for the opt-in parameter to be opt-out at some point?

@sfc-gh-evandenberg
Copy link
Collaborator Author

Will we plan for the opt-in parameter to be opt-out at some point?

@sfc-gh-yixie @sfc-gh-aalam Any thoughts here? I'm not sure describe queries are as interesting to track by default but may make sense at some point.

Copy link
Contributor

@sfc-gh-helmeleegy sfc-gh-helmeleegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thanks, Eric!

@sfc-gh-aalam
Copy link
Contributor

Will we plan for the opt-in parameter to be opt-out at some point?

@sfc-gh-yixie @sfc-gh-aalam Any thoughts here? I'm not sure describe queries are as interesting to track by default but may make sense at some point.

I think this is minor enough that we can keep it opt-in forever.

@sfc-gh-evandenberg sfc-gh-evandenberg force-pushed the evandenberg-SNOW-1557539-count-describe-queries-for-test-2 branch from 37b778d to 7e4d4a6 Compare September 17, 2024 17:25
@sfc-gh-evandenberg sfc-gh-evandenberg force-pushed the evandenberg-SNOW-1557539-count-describe-queries-for-test-2 branch from 7e4d4a6 to b7afd8c Compare September 17, 2024 20:02
This adds reporting of describe queries when running tests.
@sfc-gh-evandenberg sfc-gh-evandenberg merged commit 7ffc5c3 into main Sep 18, 2024
36 checks passed
@sfc-gh-evandenberg sfc-gh-evandenberg deleted the evandenberg-SNOW-1557539-count-describe-queries-for-test-2 branch September 18, 2024 17:42
@github-actions github-actions bot locked and limited conversation to collaborators Sep 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs snowpark-pandas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants