SNOW-1557539 count describe queries for test#2249
Merged
sfc-gh-evandenberg merged 13 commits intomainfrom Sep 18, 2024
Merged
Conversation
sfc-gh-yixie
reviewed
Sep 6, 2024
aaa5882 to
53e512a
Compare
sfc-gh-aalam
reviewed
Sep 9, 2024
53e512a to
11fab71
Compare
sfc-gh-aalam
approved these changes
Sep 13, 2024
sfc-gh-yixie
approved these changes
Sep 13, 2024
ee48e09 to
18f73f0
Compare
Contributor
|
Will we plan for the opt-in parameter to be opt-out at some point? |
Collaborator
Author
@sfc-gh-yixie @sfc-gh-aalam Any thoughts here? I'm not sure describe queries are as interesting to track by default but may make sense at some point. |
sfc-gh-helmeleegy
approved these changes
Sep 17, 2024
Contributor
sfc-gh-helmeleegy
left a comment
There was a problem hiding this comment.
LGTM. thanks, Eric!
Contributor
I think this is minor enough that we can keep it opt-in forever. |
37b778d to
7e4d4a6
Compare
7e4d4a6 to
b7afd8c
Compare
This adds reporting of describe queries when running tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-1557539 count describe queries for test
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Add describe query to query listener history (opt-in)