-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-1557539 count describe queries for test #2249
SNOW-1557539 count describe queries for test #2249
Conversation
aaa5882
to
53e512a
Compare
53e512a
to
11fab71
Compare
ee48e09
to
18f73f0
Compare
Will we plan for the opt-in parameter to be opt-out at some point? |
@sfc-gh-yixie @sfc-gh-aalam Any thoughts here? I'm not sure describe queries are as interesting to track by default but may make sense at some point. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. thanks, Eric!
I think this is minor enough that we can keep it opt-in forever. |
37b778d
to
7e4d4a6
Compare
7e4d4a6
to
b7afd8c
Compare
This adds reporting of describe queries when running tests.
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-1557539 count describe queries for test
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Add describe query to query listener history (opt-in)