-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Capture AST for DataFrame.pivot and DataFrame.unpivot #2287
Merged
sfc-gh-oplaton
merged 34 commits into
ls-SNOW-1491199-merge-phase0-server-side
from
oplaton/SNOW-1491297-pivot
Sep 13, 2024
Merged
Capture AST for DataFrame.pivot and DataFrame.unpivot #2287
sfc-gh-oplaton
merged 34 commits into
ls-SNOW-1491199-merge-phase0-server-side
from
oplaton/SNOW-1491297-pivot
Sep 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will update the expected AST and Python
The test still fails with an unexpected exception
sfc-gh-oplaton
requested review from
sfc-gh-lspiegelberg,
sfc-gh-vbudati and
sfc-gh-azwiegincew
September 12, 2024 20:40
sfc-gh-oplaton
requested review from
sfc-gh-yixie,
sfc-gh-yuwang and
sfc-gh-aalam
and removed request for
a team,
sfc-gh-yixie,
sfc-gh-yuwang and
sfc-gh-aalam
September 12, 2024 20:40
Few nits, do you have by chance the error that happens in local testing mode for unpivot? |
The verbatim error is:
|
sfc-gh-lspiegelberg
approved these changes
Sep 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
sfc-gh-oplaton
merged commit Sep 13, 2024
f01c914
into
ls-SNOW-1491199-merge-phase0-server-side
9 of 30 checks passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-1491297
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Capture AST for
DataFrame.pivot
andDataFrame.unpivot
.Add expectation test for
pivot
.I was unable to resolve the local testing issue for
unpivot
. Adding a disabled test for now, and will revisit the test issue separately.