Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1665697: add open_new_result in document API #2313

Merged
merged 9 commits into from
Sep 23, 2024

Conversation

sfc-gh-zhan
Copy link
Contributor

Description
add open_new_result in document API, https://docs.snowflake.com/en/developer-guide/snowpark/reference/python/1.8.0/api/snowflake.snowpark.files.SnowflakeFile.open

Testing
add unit test

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1665697

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

Copy link

github-actions bot commented Sep 17, 2024

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@sfc-gh-zhan
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

Description

Testing
@sfc-gh-zhan
Copy link
Contributor Author

Hi @sfc-gh-aalam looks like I'm not authorized to merge, could you help to merge it? thanks!

@sfc-gh-aalam sfc-gh-aalam enabled auto-merge (squash) September 23, 2024 17:13
@sfc-gh-aalam sfc-gh-aalam merged commit 781852a into main Sep 23, 2024
33 of 34 checks passed
@sfc-gh-aalam sfc-gh-aalam deleted the zhan-SNOW-1665697-update-write-api branch September 23, 2024 18:57
@github-actions github-actions bot locked and limited conversation to collaborators Sep 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants