Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1709861: table clean up uses its own cursor #2448

Merged

Conversation

sfc-gh-aling
Copy link
Contributor

@sfc-gh-aling sfc-gh-aling commented Oct 14, 2024

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-NNNNNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe
  3. Please describe how your code solves the related issue.

auto table clean up could be kicked off by python gc at random timing, this caused flakiness in our async query execution as the random execution of async table clean up might overwrite the status of the shared session object leading to incorrect async query id being stored.

to improve, here we create a low level new connector cursor to execute drop temp table each time to avoid side effect

@sfc-gh-aling sfc-gh-aling force-pushed the SNOW-1709861-result-scan-on-result-of-show-tables-is-flaky branch from 5fefb00 to 0857ee2 Compare October 14, 2024 23:03
@sfc-gh-aling
Copy link
Contributor Author

successful daily precommit running without any flaky test: https://github.com/snowflakedb/snowpark-python/actions/runs/11372006647

@sfc-gh-aling sfc-gh-aling merged commit 7dc2670 into main Oct 17, 2024
34 checks passed
@sfc-gh-aling sfc-gh-aling deleted the SNOW-1709861-result-scan-on-result-of-show-tables-is-flaky branch October 17, 2024 22:23
@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants