-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-1709861: table clean up uses its own cursor #2448
Merged
sfc-gh-aling
merged 13 commits into
main
from
SNOW-1709861-result-scan-on-result-of-show-tables-is-flaky
Oct 17, 2024
Merged
SNOW-1709861: table clean up uses its own cursor #2448
sfc-gh-aling
merged 13 commits into
main
from
SNOW-1709861-result-scan-on-result-of-show-tables-is-flaky
Oct 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-aling
force-pushed
the
SNOW-1709861-result-scan-on-result-of-show-tables-is-flaky
branch
from
October 14, 2024 23:03
5fefb00
to
0857ee2
Compare
…lt-of-show-tables-is-flaky' into SNOW-1709861-result-scan-on-result-of-show-tables-is-flaky
sfc-gh-aling
requested review from
sfc-gh-smirzaei,
sfc-gh-yixie,
sfc-gh-jrose,
sfc-gh-jdu and
sfc-gh-aalam
October 15, 2024 23:30
sfc-gh-aling
commented
Oct 15, 2024
sfc-gh-jdu
reviewed
Oct 16, 2024
successful daily precommit running without any flaky test: https://github.com/snowflakedb/snowpark-python/actions/runs/11372006647 |
sfc-gh-jdu
approved these changes
Oct 17, 2024
sfc-gh-aalam
approved these changes
Oct 17, 2024
sfc-gh-aling
deleted the
SNOW-1709861-result-scan-on-result-of-show-tables-is-flaky
branch
October 17, 2024 22:23
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-NNNNNNN
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
auto table clean up could be kicked off by python gc at random timing, this caused flakiness in our async query execution as the random execution of async table clean up might overwrite the status of the shared session object leading to incorrect async query id being stored.
to improve, here we create a low level new connector cursor to execute drop temp table each time to avoid side effect