Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Local testing] Reset table index on read #2482

Closed
wants to merge 4 commits into from

Conversation

tvdboom
Copy link

@tvdboom tvdboom commented Oct 19, 2024

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1753336

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
  3. Please describe how your code solves the related issue.

    All tables get their index reset when reading it in. This solves the reported issue downstream.
    Also updated the changelog with some bug fixes that were attributed to release 1.23.0 but are actually part of 1.24

@tvdboom
Copy link
Author

tvdboom commented Oct 19, 2024

@sfc-gh-jrose could you review this one?

@tvdboom
Copy link
Author

tvdboom commented Oct 25, 2024

@sfc-gh-jrose any idea when this will be reviewed?

@sfc-gh-jrose
Copy link
Contributor

@sfc-gh-jrose any idea when this will be reviewed?

I've opened another PR to get the actions to run correctly. Looks like there's a few test failures. I can address those next week.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants