Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1787415 Fix dataframe join with sort deterministic #2591

Conversation

sfc-gh-evandenberg
Copy link
Collaborator

SNOW-1787415 Fix dataframe join with sort deterministic

…mns for ast replay

Fix full_ast_validation bug to clear ast batch from prior test if was not executed.
@sfc-gh-evandenberg sfc-gh-evandenberg requested review from sfc-gh-jdu, sfc-gh-yuwang and sfc-gh-jrose and removed request for a team November 8, 2024 17:55
@sfc-gh-oplaton
Copy link
Contributor

If this patch doesn't have a hard dependency on AST logic, please consider merging into main instead.

Copy link
Contributor

@sfc-gh-lspiegelberg sfc-gh-lspiegelberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, similar to Ovidiu's comment on slack - we prob. could push the fix directly to snowpark python's main branch.

@sfc-gh-evandenberg sfc-gh-evandenberg merged commit d1eb1a6 into ls-SNOW-1491199-merge-phase0-server-side Nov 8, 2024
6 checks passed
@sfc-gh-evandenberg sfc-gh-evandenberg deleted the evandenberg-SNOW-1787415-fix-dataframe-join-with-sort-deterministic branch November 8, 2024 18:14
@github-actions github-actions bot locked and limited conversation to collaborators Nov 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants