Skip to content

Commit 0bf3b76

Browse files
committed
Fix atomic property keys in trackWebViewEvent
1 parent 8e8143f commit 0bf3b76

File tree

2 files changed

+19
-18
lines changed

2 files changed

+19
-18
lines changed

src/api.ts

+6-6
Original file line numberDiff line numberDiff line change
@@ -49,9 +49,9 @@ export interface AtomicProperties {
4949
/** The browser useragent. */
5050
useragent?: string;
5151
/** For page view events. The page URL. */
52-
url?: string;
52+
pageUrl?: string;
5353
/** For page view events. The page title. */
54-
title?: string;
54+
pageTitle?: string;
5555
/** For page view events. The referrer URL. */
5656
referrer?: string;
5757
/** For structured events. Name for the group of objects you want to track. */
@@ -65,13 +65,13 @@ export interface AtomicProperties {
6565
/** For structured events. Quantifies or further describes the user action. */
6666
value?: number;
6767
/** For page ping events. The minimum X offset. */
68-
minXOffset?: number;
68+
pingXOffsetMin?: number;
6969
/** For page ping events. The maximum X offset. */
70-
maxXOffset?: number;
70+
pingXOffsetMax?: number;
7171
/** For page ping events. The minimum Y offset. */
72-
minYOffset?: number;
72+
pingYOffsetMin?: number;
7373
/** For page ping events. The maximum Y offset. */
74-
maxYOffset?: number;
74+
pingYOffsetMax?: number;
7575
}
7676

7777
/**

test/reactNative.test.ts

+13-12
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ import {
1616
trackStructEvent,
1717
trackWebViewEvent,
1818
} from '../src';
19+
import { AtomicProperties } from '../src/api';
1920

2021
describe('React Native interface', () => {
2122
let windowSpy: any;
@@ -36,14 +37,14 @@ describe('React Native interface', () => {
3637
});
3738

3839
it('track a webview primitive event', () => {
39-
const atomic = {
40+
const atomic: AtomicProperties = {
4041
eventName: 'pp',
4142
trackerVersion: 'webview',
42-
url: 'http://test.com',
43-
minXOffset: 20,
44-
maxXOffset: 30,
45-
minYOffset: 40,
46-
maxYOffset: 50,
43+
pageUrl: 'http://test.com',
44+
pingXOffsetMin: 20,
45+
pingXOffsetMax: 30,
46+
pingYOffsetMin: 40,
47+
pingYOffsetMax: 50,
4748
};
4849

4950
trackWebViewEvent({ properties: atomic }, ['ns1', 'ns2']);
@@ -54,19 +55,19 @@ describe('React Native interface', () => {
5455
event: {
5556
eventName: 'pp',
5657
trackerVersion: 'webview',
57-
url: 'http://test.com',
58-
minXOffset: 20,
59-
maxXOffset: 30,
60-
minYOffset: 40,
61-
maxYOffset: 50,
58+
pageUrl: 'http://test.com',
59+
pingXOffsetMin: 20,
60+
pingXOffsetMax: 30,
61+
pingYOffsetMin: 40,
62+
pingYOffsetMax: 50,
6263
},
6364
trackers: ['ns1', 'ns2'],
6465
})
6566
);
6667
});
6768

6869
it('tracks a webview self-describing event', () => {
69-
const atomic = {
70+
const atomic: AtomicProperties = {
7071
eventName: 'ue',
7172
trackerVersion: 'webview',
7273
};

0 commit comments

Comments
 (0)