Skip to content

Commit fcf393d

Browse files
committed
Clean up net_util unit tests for C++.
1 parent b931667 commit fcf393d

File tree

1 file changed

+10
-12
lines changed

1 file changed

+10
-12
lines changed

test/test_net_util.cc

Lines changed: 10 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -9,20 +9,19 @@
99

1010
TEST(net_util, my_ip_address) {
1111
char *address = my_ip_address();
12-
EXPECT_TRUE(address != NULL);
12+
EXPECT_NE(address, nullptr);
1313
if (address) {
14-
EXPECT_TRUE(strstr(address, ".") != NULL);
15-
EXPECT_TRUE(strstr(address, ";") == NULL);
16-
EXPECT_TRUE(strstr(address, ":") == NULL);
14+
EXPECT_NE(strchr(address, '.'), nullptr);
15+
EXPECT_EQ(strpbrk(address, ";:"), nullptr);
1716
free(address);
1817
}
1918
}
2019

2120
TEST(net_util, my_ip_address_ex) {
2221
char *addresses = my_ip_address_ex();
23-
EXPECT_TRUE(addresses != NULL);
22+
EXPECT_NE(addresses, nullptr);
2423
if (addresses) {
25-
EXPECT_TRUE(strstr(addresses, ".") != NULL || strstr(addresses, ":") != NULL);
24+
EXPECT_NE(strpbrk(addresses, ".:"), nullptr);
2625
free(addresses);
2726
}
2827
}
@@ -31,11 +30,10 @@ TEST(net_util, dns_resolve_google) {
3130
int32_t error = 0;
3231
char *ip = dns_resolve("google.com", &error);
3332
EXPECT_EQ(error, 0);
34-
EXPECT_TRUE(ip != NULL);
33+
EXPECT_NE(ip, nullptr);
3534
if (ip) {
36-
EXPECT_TRUE(strstr(ip, ".") != NULL);
37-
EXPECT_TRUE(strstr(ip, ";") == NULL);
38-
EXPECT_TRUE(strstr(ip, ":") == NULL);
35+
EXPECT_NE(strstr(ip, "."), nullptr);
36+
EXPECT_EQ(strpbrk(ip, ";:"), nullptr);
3937
free(ip);
4038
}
4139
}
@@ -51,9 +49,9 @@ TEST(net_util, dns_ex_resolve_google) {
5149
int32_t error = 0;
5250
char *ips = dns_resolve_ex("google.com", &error);
5351
EXPECT_EQ(error, 0);
54-
EXPECT_TRUE(ips != NULL);
52+
EXPECT_NE(ips, nullptr);
5553
if (ips) {
56-
EXPECT_TRUE(strstr(ips, ".") != NULL || strstr(ips, ":") != NULL);
54+
EXPECT_NE(strpbrk(ips, ".:"), nullptr);
5755
free(ips);
5856
}
5957
}

0 commit comments

Comments
 (0)