Skip to content

Commit dbb4547

Browse files
authored
build: fix installation and change build default flags (#372)
* Change default submodules and fix install issue The wrong target was used for installation of targets * Disable flag as we changed the default
1 parent 973baa3 commit dbb4547

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

Diff for: .github/workflows/ci.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,4 +23,4 @@ jobs:
2323
submodule_update: ON
2424
run_tests: ON
2525
unit_test_build: -DBUILD_UNIT_TESTS=ON
26-
cmake_args: -DCMAKE_CXX_FLAGS=-std=c++11;-DUSE_SUBMODULES=ON
26+
cmake_args: -DCMAKE_CXX_FLAGS=-std=c++11

Diff for: CMakeLists.txt

+2-2
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ PROJECT(sioclient
66

77
option(BUILD_SHARED_LIBS "Build the shared library" OFF)
88
option(BUILD_UNIT_TESTS "Builds unit tests target" OFF)
9-
option(USE_SUBMODULES "Use source in local submodules instead of system libraries" OFF)
9+
option(USE_SUBMODULES "Use source in local submodules instead of system libraries" ON)
1010

1111
set(MAJOR 1)
1212
set(MINOR 6)
@@ -158,7 +158,7 @@ install(
158158
FILES
159159
"${CMAKE_CURRENT_BINARY_DIR}/sioclient/sioclientConfig.cmake"
160160
"${CMAKE_CURRENT_BINARY_DIR}/sioclient/sioclientConfigVersion.cmake"
161-
"${CMAKE_CURRENT_BINARY_DIR}/sioclient/sioclientConfigTargets.cmake"
161+
"${CMAKE_CURRENT_BINARY_DIR}/sioclient/sioclientTargets.cmake"
162162
DESTINATION
163163
${ConfigPackageLocation}
164164
)

0 commit comments

Comments
 (0)