Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extra methods #40

Open
christianbundy opened this issue Sep 8, 2020 · 1 comment · May be fixed by #42
Open

Extra methods #40

christianbundy opened this issue Sep 8, 2020 · 1 comment · May be fixed by #42

Comments

@christianbundy
Copy link
Contributor

It looks like Sodium-Native API is a subset of the libsodium API, but the Sodium-Javascript has some extra methods not found in either:

  • crypto_verify_16
  • crypto_verify_32
  • crypto_box_ZEROBYTES
  • crypto_box_BOXZEROBYTES
  • crypto_box_BEFORENMBYTES
  • crypto_generichash_WASM_SUPPORTED
  • crypto_generichash_WASM_LOADED
  • crypto_generichash_ready
  • crypto_generichash_instance
  • crypto_secretbox
  • crypto_secretbox_open
  • crypto_secretbox_ZEROBYTES
  • crypto_secretbox_BOXZEROBYTES
  • crypto_shorthash_WASM_SUPPORTED
  • crypto_shorthash_WASM_LOADED
  • crypto_stream_xor_instance
  • crypto_stream_chacha20_xor_instance
  • crypto_stream_chacha20_ietf_xor_instance

There are three types of extra methods:

  • Methods found in libsodium but not Sodium-Native.
  • Methods specific to WASM (maybe generichash_ready should be generichash_wasm_ready?)
  • Methods suffixed with _instance, which were previously in Sodium-Native but have been removed (replaced by _init, _update, and _final?).

Should any/all of these be removed or replaced?
@christianbundy
Copy link
Contributor Author

After talking about this a bit in IRC, it sounds like methods can be removed if:

  • They're not in sodium-native.
  • They're don't mention wasm.
  • They aren't _instance legacy methods.

@christianbundy christianbundy linked a pull request Sep 11, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BREAKING: Remove unused exported methods christianbundy/sodium-javascript
1 participant
@christianbundy