Skip to content

Commit 2ad43fe

Browse files
authored
[Web] Fix KeyboardEventManager listeners unmount (#3126)
## Description For some reason `KeyboardEventManager` uses `addEventListener` inside `unregisterListeners` method. This PR changes it to `removeEventListener`, so that listeners are correctly removed from elements. ## Test plan I've tested that on my branch with removing `findNodeHandle`, so... you can trust me since `PointerEventManager` uses [the same logic](https://github.com/software-mansion/react-native-gesture-handler/blob/10f1e0c69cc945d1b529326eee27583c87ca66c0/src/web/tools/PointerEventManager.ts#L190) 😄
1 parent 10f1e0c commit 2ad43fe

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/web/tools/KeyboardEventManager.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -57,8 +57,8 @@ export default class KeyboardEventManager extends EventManager<HTMLElement> {
5757
}
5858

5959
public unregisterListeners(): void {
60-
this.view.addEventListener('keydown', this.keyDownCallback);
61-
this.view.addEventListener('keyup', this.keyUpCallback);
60+
this.view.removeEventListener('keydown', this.keyDownCallback);
61+
this.view.removeEventListener('keyup', this.keyUpCallback);
6262
}
6363

6464
protected mapEvent(

0 commit comments

Comments
 (0)