Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not compatiable wtih RN 0.77.0-rc.4 #3308

Closed
kprabath opened this issue Dec 25, 2024 · 2 comments
Closed

Not compatiable wtih RN 0.77.0-rc.4 #3308

kprabath opened this issue Dec 25, 2024 · 2 comments
Labels
Missing repro Platform: Android This issue is specific to Android

Comments

@kprabath
Copy link

kprabath commented Dec 25, 2024

Description

I installed react-native-gesture handler for my RN 77+ project which has support for Android 15 page size memory.
It seems com.facebook.react.uimanager.BaseViewManagerInterface class has been removed and RN team has done few more changes to their core libraries because gestured handler depend on those compilation error is thrown.

node_modules/react-native-gesture-handler/android/src/main/java/com/swmansion/gesturehandler/RNGestureHandlerPackage.kt:22:1 Class 'RNGestureHandlerPackage' is not abstract and does not implement abstract member public abstract fun getViewManagerNames(reactContext: ReactApplicationContext): Collection defined in com.facebook.react.ViewManagerOnDemandReactPackage
node_modules/react-native-gesture-handler/android/src/main/java/com/swmansion/gesturehandler/RNGestureHandlerPackage.kt:40:3 'getViewManagerNames' overrides nothing
node_modules/react-native-gesture-handler/android/src/main/java/com/swmansion/gesturehandler/RNGestureHandlerPackage.kt:43:3 'getViewManagers' overrides nothing
node_modules/react-native-gesture-handler/android/src/main/java/com/swmansion/gesturehandler/RNGestureHandlerPackage.kt:46:3 'createViewManager' overrides nothing
node_modules/react-native-gesture-handler/android/src/main/java/com/swmansion/gesturehandler/react/RNGestureHandlerButtonViewManager.kt:43:72 Type argument is not within its bounds: should be subtype of 'BaseViewManagerInterface!'
node_modules/react-native-gesture-handler/android/src/main/java/com/swmansion/gesturehandler/react/RNGestureHandlerRootViewManager.kt:22:83 Type argument is not within its bounds: should be subtype of 'BaseViewManagerInterface!'

Steps to reproduce

Setup a RN project with 0.77.0-rc.4.
Install the gesture handler and try to run the project

Snack or a link to a repository

no link

Gesture Handler version

2.21.2

React Native version

0.77.0-rc.4

Platforms

Android

JavaScript runtime

Hermes

Workflow

React Native (without Expo)

Architecture

Paper (Old Architecture)

Build type

Debug mode

Device

Android emulator

Device model

No response

Acknowledgements

Yes

Copy link

Hey! 👋

The issue doesn't seem to contain a minimal reproduction.

Could you provide a snack or a link to a GitHub repository under your username that reproduces the problem?

@github-actions github-actions bot added Missing repro Platform: Android This issue is specific to Android labels Dec 25, 2024
@m-bert
Copy link
Contributor

m-bert commented Jan 7, 2025

Hi @kprabath! I've just built our apps on 0.77.0-rc.6 and it builds correctly. Issues that you've mentioned were fixed in #3278. However, they have not been released yet.

@m-bert m-bert closed this as completed Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Missing repro Platform: Android This issue is specific to Android
Projects
None yet
Development

No branches or pull requests

2 participants