Skip to content

Commit d5a6bd1

Browse files
authored
Fix assert macros (#1563)
1 parent 2320962 commit d5a6bd1

File tree

4 files changed

+35
-7
lines changed

4 files changed

+35
-7
lines changed

scarb/src/compiler/plugin/builtin.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ impl CairoPlugin for BuiltinTestAssertsPlugin {
112112
fn id(&self) -> PackageId {
113113
PackageId::new(
114114
PackageName::TEST_ASSERTS_PLUGIN,
115-
semver::Version::new(0, 1, 0),
115+
crate::version::get().cairo.version.to_version().unwrap(),
116116
SourceId::for_std(),
117117
)
118118
}

scarb/src/ops/resolve.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ pub fn resolve_workspace_with_opts(
102102
ManifestDependency::builder()
103103
.kind(DepKind::Target(TargetKind::TEST))
104104
.name(PackageName::TEST_ASSERTS_PLUGIN)
105-
.version_req(DependencyVersionReq::exact(&semver::Version::new(0, 1, 0)))
105+
.version_req(version_req.clone())
106106
.source_id(SourceId::for_std())
107107
.build(),
108108
],

scarb/tests/test_subcommand.rs

+20
Original file line numberDiff line numberDiff line change
@@ -73,3 +73,23 @@ fn errors_when_missing_script_and_cairo_test() {
7373
error: no such command: `cairo-test`
7474
"#});
7575
}
76+
77+
#[test]
78+
fn assert_macros_available() {
79+
let t = TempDir::new().unwrap();
80+
ProjectBuilder::start()
81+
.dev_dep_builtin("assert_macros")
82+
.dep_cairo_test()
83+
.lib_cairo(indoc! {r#"
84+
#[test]
85+
fn some() {
86+
assert_eq!(1, 1);
87+
}
88+
"#})
89+
.build(&t);
90+
Scarb::quick_snapbox()
91+
.args(["build", "--test"])
92+
.current_dir(&t)
93+
.assert()
94+
.success();
95+
}

utils/scarb-test-support/src/project_builder.rs

+13-5
Original file line numberDiff line numberDiff line change
@@ -93,16 +93,24 @@ impl ProjectBuilder {
9393
self
9494
}
9595

96-
pub fn dep_starknet(self) -> Self {
97-
self.dep("starknet", Dep.version(CAIRO_VERSION))
96+
pub fn dep_builtin(self, name: impl ToString) -> Self {
97+
self.dep(name, Dep.version(CAIRO_VERSION))
9898
}
9999

100-
pub fn dep_cairo_test(self) -> Self {
101-
self.dev_dep("cairo_test", Dep.version(CAIRO_VERSION))
100+
pub fn dev_dep_builtin(self, name: impl ToString) -> Self {
101+
self.dev_dep(name, Dep.version(CAIRO_VERSION))
102102
}
103103

104104
pub fn dep_cairo_run(self) -> Self {
105-
self.dep("cairo_run", Dep.version(CAIRO_VERSION))
105+
self.dep_builtin("cairo_run")
106+
}
107+
108+
pub fn dep_starknet(self) -> Self {
109+
self.dep_builtin("starknet")
110+
}
111+
112+
pub fn dep_cairo_test(self) -> Self {
113+
self.dev_dep_builtin("cairo_test")
106114
}
107115

108116
pub fn manifest_package_extra(mut self, extra: impl ToString) -> Self {

0 commit comments

Comments
 (0)