Skip to content

Commit 892b1e5

Browse files
Skip test scripts using conditional mark
1 parent b4fc61a commit 892b1e5

File tree

2 files changed

+42
-12
lines changed

2 files changed

+42
-12
lines changed

tests/common/plugins/conditional_mark/tests_mark_conditions.yaml

Lines changed: 42 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -64,35 +64,41 @@ arp/test_wr_arp.py:
6464
#######################################
6565
bfd/test_bfd.py:
6666
skip:
67-
reason: "Test not supported for platforms other than Nvidia 4600c/4700/5600 and cisco-8102. Skipping the test"
67+
reason: "Test not supported for platforms other than Nvidia 4600c/4700/5600 and cisco-8102. Skipping the test / KVM do not support bfd test"
68+
conditions_logical_operator: or
6869
conditions:
6970
- "(release in ['201811', '201911']) or (platform not in ['x86_64-mlnx_msn4600c-r0', 'x86_64-mlnx_msn4700-r0', 'x86_64-nvidia_sn5600-r0', 'x86_64-8102_64h_o-r0', 'x86_64-8101_32fh_o-r0'])"
71+
- "asic_type in ['vs']"
7072

7173
bfd/test_bfd.py::test_bfd_basic:
7274
skip:
7375
reason: "Test not supported for cisco as it doesnt support single hop BFD
74-
and not supported for platforms other than Nvidia 4600c/4700/5600. Skipping the test"
76+
and not supported for platforms other than Nvidia 4600c/4700/5600. Skipping the test / KVM do not support bfd test"
7577
conditions_logical_operator: or
7678
conditions:
7779
- "platform in ['x86_64-8102_64h_o-r0', 'x86_64-8101_32fh_o-r0', 'x86_64-8111_32eh_o-r0', 'x86_64-8122_64eh_o-r0', 'x86_64-8122_64ehf_o-r0']"
7880
- "platform not in ['x86_64-mlnx_msn4600c-r0', 'x86_64-mlnx_msn4700-r0', 'x86_64-nvidia_sn5600-r0', 'x86_64-8102_64h_o-r0', 'x86_64-8101_32fh_o-r0']"
7981
- "release in ['201811', '201911']"
82+
- "asic_type in ['vs']"
8083

8184
bfd/test_bfd.py::test_bfd_echo_mode:
8285
skip:
83-
reason: "https://github.com/sonic-net/sonic-mgmt/issues/14087"
86+
reason: "https://github.com/sonic-net/sonic-mgmt/issues/14087 / KVM do not support bfd test"
87+
conditions_logical_operator: or
8488
conditions:
8589
- "https://github.com/sonic-net/sonic-mgmt/issues/14087"
90+
- "asic_type in ['vs']"
8691

8792
bfd/test_bfd.py::test_bfd_scale:
8893
skip:
8994
reason: "Test is not verified for cisco-8111 and cisco-8122 yet.
90-
and not supported for platforms other than Nvidia 4600c/4700/5600. Skipping the test"
95+
and not supported for platforms other than Nvidia 4600c/4700/5600. Skipping the test / KVM do not support bfd test"
9196
conditions_logical_operator: or
9297
conditions:
9398
- "platform in ['x86_64-8111_32eh_o-r0', 'x86_64-8122_64eh_o-r0', 'x86_64-8122_64ehf_o-r0']"
9499
- "platform not in ['x86_64-mlnx_msn4600c-r0', 'x86_64-mlnx_msn4700-r0', 'x86_64-nvidia_sn5600-r0', 'x86_64-8102_64h_o-r0', 'x86_64-8101_32fh_o-r0']"
95100
- "release in ['201811', '201911']"
101+
- "asic_type in ['vs']"
96102

97103
bfd/test_bfd_static_route.py:
98104
skip:
@@ -556,6 +562,12 @@ dualtor_io:
556562
conditions:
557563
- "'dualtor' not in topo_name"
558564

565+
dualtor_io/test_grpc_server_failure.py:
566+
skip:
567+
reason: "This test only support on dualtor-aa testbed"
568+
conditions:
569+
- "'dualtor-aa' not in topo_name"
570+
559571
dualtor_io/test_link_failure.py::test_active_link_admin_down_config_reload_link_up_downstream_standby[active-active]:
560572
xfail:
561573
reason: "Testcase ignored on mellanox setups due to github issue: https://github.com/sonic-net/sonic-buildimage/issues/16161"
@@ -644,6 +656,12 @@ dualtor_mgmt/test_dualtor_bgp_update_delay.py:
644656
- asic_type in ['vs']
645657
- https://github.com/sonic-net/sonic-mgmt/issues/14996
646658

659+
dualtor_mgmt/test_egress_drop_nvidia.py:
660+
skip:
661+
reason: "This test is only for Nvidia platforms."
662+
conditions:
663+
- "asic_type not in ['mellanox']"
664+
647665
dualtor_mgmt/test_server_failure.py::test_server_reboot:
648666
skip:
649667
reason: "KVM testbed does not have fanout hosts"
@@ -1292,6 +1310,15 @@ ipfwd/test_mtu.py:
12921310
conditions:
12931311
- "topo_type not in ['t1', 't2']"
12941312

1313+
#######################################
1314+
##### ixia #####
1315+
#######################################
1316+
ixia:
1317+
skip:
1318+
reason: "Ixia test only support on physical ixia testbed"
1319+
conditions:
1320+
- "asic_type in ['vs']"
1321+
12951322
#######################################
12961323
##### k8s #####
12971324
#######################################
@@ -1996,17 +2023,25 @@ show_techsupport/test_auto_techsupport.py::TestAutoTechSupport::test_sai_sdk_dum
19962023
#######################################
19972024
##### snappi_tests #####
19982025
#######################################
2026+
snappi_tests:
2027+
skip:
2028+
reason: "Snappi test only support on physical tgen testbed"
2029+
conditions:
2030+
- "asic_type in ['vs']"
2031+
19992032
snappi_tests/ecn/test_red_accuracy_with_snappi:
20002033
skip:
2001-
reason: "Test should not be run as part of nightly."
2034+
reason: "Test should not be run as part of nightly. / Snappi test only support on physical tgen testbed"
2035+
conditions_logical_operator: or
20022036
conditions:
20032037
- "topo_type in ['tgen']"
2038+
- "asic_type in ['vs']"
20042039

20052040
snappi_tests/multidut/pfc/test_multidut_global_pause_with_snappi.py:
20062041
skip:
2007-
reason: "Global pause is not supported in cisco-8000."
2042+
reason: "Global pause is not supported in cisco-8000. / Snappi test only support on physical tgen testbed"
20082043
conditions:
2009-
- "asic_type in ['cisco-8000']"
2044+
- "asic_type in ['cisco-8000', 'vs']"
20102045

20112046
#######################################
20122047
##### snmp #####

tests/dualtor_mgmt/test_egress_drop_nvidia.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -31,11 +31,6 @@
3131
# These two test cases are to cover the test gap introduced by the egress drop.
3232

3333

34-
@pytest.fixture(scope="module", autouse=True)
35-
def skip_non_nvidia_platforms(lower_tor_host): # noqa F811
36-
if "mellanox" != lower_tor_host.facts["asic_type"]:
37-
pytest.skip("This test is only for Nvidia platforms.")
38-
3934
def test_egress_drop_standby_server_to_active_server(ptfhost, upper_tor_host, lower_tor_host, # noqa F811
4035
toggle_all_simulator_ports_to_upper_tor, # noqa F811
4136
toggle_simulator_port_to_lower_tor, tbinfo, ptfadapter): # noqa F811

0 commit comments

Comments
 (0)