Enhancement: [sflow] Enable test_sflow.py for 'vs' topologies #21208
Description
Is it platform specific
generic
Importance or Severity
High
Description of the enhancement
Currently, sflow/test_sflow.py is disabled for virtual topologies, and is being skipped for those topos. This is unfortunate, because the community test suite relies on virtual testbeds to test against when changes are made to sonic-mgmt. This means that changes made to sflow/test_sflow.py are not validated against the community test infrastructure, which creates a test gap as we do not do any verification of those changes (the test is skipped and marked as PASSED without ever running any testcases).
I ran the test against a virtual topology and it seems to pass just fine. I'm not sure what the original logic was, as the skip has been moved around through several files and I can't find the first reference, but I think if the test passes on the topo then it should be safe to remove the skip.
If we want the test to run on the community infra, however, we'll need to add logic to enable sflow for that test explicitly. This could be done at the infrastructure level by passing --enable_sflow_feature to the test when it's run as part of the CI/CD pipeline, although since I don't have access to that process I'm not sure how possible that is. The alternative is to always enable the feature when the test is run on a virtual topology. That's probably not a bad approach, since we generally assume that the whole point of having a virtual topology is to run this explicit test (whereas a physical testbed may be set to test non-standard configuration or network structure).
Current Behavior
The test is skipped for VS topos.
Proposed Behavior
The test runs on VS topos.