Address community review comments

stephenxs · stephenxs · commit 06c30ce46c8d · 2025-11-12T15:09:20.000+08:00
Signed-off-by: Stephen Sun &lt;stephens@nvidia.com&gt;
diff --git a/orchagent/switchorch.cpp b/orchagent/switchorch.cpp
@@ -1872,8 +1872,8 @@ void SwitchOrch::querySwitchPortMirrorCapability()
     if (status != SAI_STATUS_SUCCESS)
     {
         SWSS_LOG_WARN("Could not query port ingress mirror capability %d", status);
-        fvVector.emplace_back(SWITCH_CAPABILITY_TABLE_PORT_INGRESS_MIRROR_CAPABLE, "false");
-        m_portIngressMirrorSupported = false;
+        fvVector.emplace_back(SWITCH_CAPABILITY_TABLE_PORT_INGRESS_MIRROR_CAPABLE, "true");
+        m_portIngressMirrorSupported = true;
     }
     else
     {
@@ -1896,8 +1896,8 @@ void SwitchOrch::querySwitchPortMirrorCapability()
     if (status != SAI_STATUS_SUCCESS)
     {
         SWSS_LOG_WARN("Could not query port egress mirror capability %d", status);
-        fvVector.emplace_back(SWITCH_CAPABILITY_TABLE_PORT_EGRESS_MIRROR_CAPABLE, "false");
-        m_portEgressMirrorSupported = false;
+        fvVector.emplace_back(SWITCH_CAPABILITY_TABLE_PORT_EGRESS_MIRROR_CAPABLE, "true");
+        m_portEgressMirrorSupported = true;
     }
     else
     {

Original file line number	Diff line number	Diff line change
`@@ -1872,8 +1872,8 @@ void SwitchOrch::querySwitchPortMirrorCapability()`
`1872`	`1872`	`if (status != SAI_STATUS_SUCCESS)`
`1873`	`1873`	`{`
`1874`	`1874`	`SWSS_LOG_WARN("Could not query port ingress mirror capability %d", status);`
`1875`		`- fvVector.emplace_back(SWITCH_CAPABILITY_TABLE_PORT_INGRESS_MIRROR_CAPABLE, "false");`
`1876`		`- m_portIngressMirrorSupported = false;`
	`1875`	`+ fvVector.emplace_back(SWITCH_CAPABILITY_TABLE_PORT_INGRESS_MIRROR_CAPABLE, "true");`
	`1876`	`+ m_portIngressMirrorSupported = true;`
`1877`	`1877`	`}`
`1878`	`1878`	`else`
`1879`	`1879`	`{`
`@@ -1896,8 +1896,8 @@ void SwitchOrch::querySwitchPortMirrorCapability()`
`1896`	`1896`	`if (status != SAI_STATUS_SUCCESS)`
`1897`	`1897`	`{`
`1898`	`1898`	`SWSS_LOG_WARN("Could not query port egress mirror capability %d", status);`
`1899`		`- fvVector.emplace_back(SWITCH_CAPABILITY_TABLE_PORT_EGRESS_MIRROR_CAPABLE, "false");`
`1900`		`- m_portEgressMirrorSupported = false;`
	`1899`	`+ fvVector.emplace_back(SWITCH_CAPABILITY_TABLE_PORT_EGRESS_MIRROR_CAPABLE, "true");`
	`1900`	`+ m_portEgressMirrorSupported = true;`
`1901`	`1901`	`}`
`1902`	`1902`	`else`
`1903`	`1903`	`{`