[routeorch] Remove updateRoute call to prevent set operations (#3923)

Ndancejic · web-flow · commit 5600c4c9bd20 · 2025-10-09T14:31:19.000-07:00
This call to updateRoute is not needed because the route entry has already been removed. It is causing unneccesary route set operations and printing harmless (but verbose) error logs. Removing this call to prevent the side-effects.

What I did
Removed call to updateRoute from removeRoutePost path.

Why I did it
This call is not needed, and is causing error logs.
diff --git a/orchagent/routeorch.cpp b/orchagent/routeorch.cpp
@@ -2895,7 +2895,6 @@ bool RouteOrch::removeRoutePost(const RouteBulkContext& ctx)
                         removeNextHopRoute(*nh, routekey);
                     }
                 }
-                mux_orch->updateRoute(ipPrefix);
             }
         }
         else if (ol_nextHops.is_overlay_nexthop())

Original file line number	Diff line number	Diff line change
`@@ -2895,7 +2895,6 @@ bool RouteOrch::removeRoutePost(const RouteBulkContext& ctx)`
`2895`	`2895`	`removeNextHopRoute(*nh, routekey);`
`2896`	`2896`	`}`
`2897`	`2897`	`}`
`2898`		`- mux_orch->updateRoute(ipPrefix);`
`2899`	`2898`	`}`
`2900`	`2899`	`}`
`2901`	`2900`	`else if (ol_nextHops.is_overlay_nexthop())`