Improve coverage

Signed-off-by: Stephen Sun <[email protected]>

Author: stephenxs

tests/mock_tests/Makefile.am

@@ -78,6 +78,7 @@ tests_SOURCES = aclorch_ut.cpp \
                 mock_dash_orch_test.cpp \
                 zmq_orch_ut.cpp \
                 mock_saihelper.cpp \
+                mirrororch_ut.cpp \
                 $(top_srcdir)/warmrestart/warmRestartHelper.cpp \
                 $(top_srcdir)/lib/gearboxutils.cpp \
                 $(top_srcdir)/lib/subintf.cpp \

tests/mock_tests/mirrororch_ut.cpp

@@ -0,0 +1,57 @@
+// Make selected privates visible for unit testing
+#define private public
+#include "directory.h"
+#undef private
+
+#define protected public
+#include "orch.h"
+#undef protected
+
+#define private public
+#include "switchorch.h"
+#undef private
+
+#include "portsorch.h"
+#define private public
+#include "mirrororch.h"
+#undef private
+#include "mock_orch_test.h"
+
+namespace mirrororch_test
+{
+    using namespace mock_orch_test;
+
+    class MirrorOrchTest : public MockOrchTest
+    {
+    };
+
+    TEST_F(MirrorOrchTest, RejectsIngressWhenUnsupported)
+    {
+        // Ensure environment initialized by MockOrchTest
+        ASSERT_NE(gSwitchOrch, nullptr);
+        ASSERT_NE(gMirrorOrch, nullptr);
+
+        // Force ingress unsupported and egress supported
+        gSwitchOrch->m_portIngressMirrorSupported = false;
+        gSwitchOrch->m_portEgressMirrorSupported = true;
+
+        Port dummyPort; // Unused due to early return
+        auto ret = gMirrorOrch->setUnsetPortMirror(dummyPort, /*ingress*/ true, /*set*/ true, /*sessionId*/ SAI_NULL_OBJECT_ID);
+        ASSERT_FALSE(ret);
+    }
+
+    TEST_F(MirrorOrchTest, RejectsEgressWhenUnsupported)
+    {
+        ASSERT_NE(gSwitchOrch, nullptr);
+        ASSERT_NE(gMirrorOrch, nullptr);
+
+        // Force egress unsupported and ingress supported
+        gSwitchOrch->m_portIngressMirrorSupported = true;
+        gSwitchOrch->m_portEgressMirrorSupported = false;
+
+        Port dummyPort; // Unused due to early return
+        auto ret = gMirrorOrch->setUnsetPortMirror(dummyPort, /*ingress*/ false, /*set*/ true, /*sessionId*/ SAI_NULL_OBJECT_ID);
+        ASSERT_FALSE(ret);
+    }
+}
+