Merge pull request #30 from sonnenkern/develop

Develop

Author: sonnenkern

lib/QuipProcessor.js

@@ -195,7 +195,7 @@ class QuipProcessor {
         this.logger.debug(`_processReference: replacement=${reference.replacement}, path=${path}`);
         return html.replace(reference.replacement, path);
     }
-    
+
     _renderDocumentHtml(html, title, path) {
         const pathDeepness = path.split("/").length-1;
 
@@ -217,7 +217,7 @@ class QuipProcessor {
 
         return html;
     }
-    
+
     async _getThreadMessagesHtml(quipThread, path) {
         let html = '';
         const pathDeepness = path.split("/").length-1;
@@ -320,12 +320,12 @@ class QuipProcessor {
     async _processDocumentThread(quipThread, path) {
         const pathDeepness = path.split("/").length-1;
         let threadHtml = quipThread.html;
-        
+
         //look up for images in html
         let matches = this._getMatchGroups(threadHtml,
             "src='(/blob/([\\w-]+)/([\\w-]+))'",
             ['replacement', 'threadId', 'blobId']);
-        
+
         //replace blob references for images
         for(const image of matches) {
             threadHtml = await this._processFile(threadHtml, image, path, this.options.embeddedImages);
@@ -423,7 +423,7 @@ class QuipProcessor {
     async _processFolders(quipFolders, path) {
         const promises = [];
         for(const index in quipFolders) {
-            promises.push(this._processFolder(quipFolders[index], `${path}${quipFolders[index].folder.title}/`));
+            promises.push(this._processFolder(quipFolders[index], `${path}${sanitizeFilename(quipFolders[index].folder.title)}/`));
         }
         await Promise.all(promises);
     }
@@ -549,4 +549,4 @@ class QuipProcessor {
     }
 }
 
-module.exports = QuipProcessor;
+module.exports = QuipProcessor;

lib/__tests__/QuipProcessor.test.js

@@ -369,8 +369,8 @@ describe('methods tests', () => {
             };
             await quipProcessor._processFolders(mockFolders, "/aaa/");
             expect(quipProcessor._processFolder).toHaveBeenCalledTimes(2);
-            expect(quipProcessor._processFolder).toHaveBeenCalledWith(mockFolders.folder1, `/aaa/${mockFolders.folder1.folder.title}/`);
-            expect(quipProcessor._processFolder).toHaveBeenCalledWith(mockFolders.folder2, `/aaa/${mockFolders.folder2.folder.title}/`);
+            expect(quipProcessor._processFolder).toHaveBeenCalledWith(mockFolders.folder1, `/aaa/${mockFolders.folder1.folder.title}_SANITIZED/`);
+            expect(quipProcessor._processFolder).toHaveBeenCalledWith(mockFolders.folder2, `/aaa/${mockFolders.folder2.folder.title}_SANITIZED/`);
         });
     });
 

package.json

@@ -1,6 +1,6 @@
 {
   "name": "quip-export",
-  "version": "2.3.0",
+  "version": "2.3.1",
   "description": "Export all folders and documents from Quip",
   "main": "index.js",
   "jest": {