Skip to content

[kdump|release] Change format of imports #4078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jcastill
Copy link
Member

Change the format of the import line for plugins
to parenthesis so it matches what we do in all
other plugins that contain multiline imports.
Also, this change ensures that the script
plugins_overview.py's output is consistent
across all plugins and doesn't contain
errors.

Related: #4071


Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • Is the subject and message clear and concise?
  • Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • Does the commit contain a Signed-off-by: First Lastname [email protected]?
  • Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?
  • Are all passwords or private data gathered by this PR obfuscated?

Change the format of the import line for plugins
to parenthesis so it matches what we do in all
other plugins that contain multiline imports.
Also, this change ensures that the script
plugins_overview.py's output is consistent
across all plugins and doesn't contain
errors.

Related: sosreport#4071

Signed-off-by: Jose Castillo <[email protected]>
@jcastill jcastill requested a review from arif-ali July 10, 2025 13:49
Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/sosreport-sos-4078
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

Copy link
Member

@arif-ali arif-ali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, makes it consistent across all the plugins

@arif-ali arif-ali added Reviewed/Needs 2nd Ack Require a 2nd ack from a maintainer Status/Needs Review This issue still needs a review from project members labels Jul 10, 2025
@TurboTurtle TurboTurtle added Reviewed/Ready for Merge Has been reviewed, ready for merge Quick Change This is likely a quick/trivial code change and removed Reviewed/Needs 2nd Ack Require a 2nd ack from a maintainer Status/Needs Review This issue still needs a review from project members labels Jul 10, 2025
@TurboTurtle TurboTurtle merged commit c1e283b into sosreport:main Jul 10, 2025
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Quick Change This is likely a quick/trivial code change Reviewed/Ready for Merge Has been reviewed, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants