You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I noticed this issue when working on bmorris3#19, which displays sky coordinates and allows editing in sky coordinates when WCS linked. If you create a composite subset with the 'remove' mode, the 'remove' sub-subset does not have a parent.coords so it doesn't have a WCS, and get_subsets(include_sky_region=True) returns None for sky_region. This creates issues when you're trying to display editable sky coordinates for that subset in the subset_plugin in my PR.
How to Reproduce
Create a composite subset using 'remove' mode on a dataset with a valid WCS (e.g imviz example notebook), run app.get_subsets(include_sky_region=True), and you will see that for the 'remove' component there is no WCS.
The text was updated successfully, but these errors were encountered:
Jdaviz component
Imviz
Description
I noticed this issue when working on bmorris3#19, which displays sky coordinates and allows editing in sky coordinates when WCS linked. If you create a composite subset with the 'remove' mode, the 'remove' sub-subset does not have a parent.coords so it doesn't have a WCS, and get_subsets(include_sky_region=True) returns None for sky_region. This creates issues when you're trying to display editable sky coordinates for that subset in the subset_plugin in my PR.
How to Reproduce
Create a composite subset using 'remove' mode on a dataset with a valid WCS (e.g imviz example notebook), run app.get_subsets(include_sky_region=True), and you will see that for the 'remove' component there is no WCS.
The text was updated successfully, but these errors were encountered: