Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a way to give a favored Vega spectrum #209

Open
eteq opened this issue Aug 16, 2019 · 2 comments
Open

Provide a way to give a favored Vega spectrum #209

eteq opened this issue Aug 16, 2019 · 2 comments

Comments

@eteq
Copy link
Contributor

eteq commented Aug 16, 2019

The built-in Vega is probably suitable for most imaginable "vegamag" needs, but for some kinds of precision work, some people may care about using a particular vega spectrum (especially given the modern suspicion that it's at least mildly variable).

So it would be useful if there were a programmatic way to provide a favorite Vega. The easiest thing might be to tell users they have to give it as a specutils.Spectrum1D, since then synphot doesn't need to worry about I/O or anything, just that it fits into the Spectrum1D API.

@pllim

This comment has been minimized.

@pllim
Copy link
Contributor

pllim commented Feb 19, 2020

With #243 merged, you can already pass in whatever Spectrum1D you want (even Vega). Does that mean this issue can be closed without further action now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants