Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Phoenix Telemetry events #23

Closed
GregMefford opened this issue Jan 2, 2020 · 2 comments · Fixed by #26
Closed

Support Phoenix Telemetry events #23

GregMefford opened this issue Jan 2, 2020 · 2 comments · Fixed by #26

Comments

@GregMefford
Copy link
Member

Phoenix will soon deprecate the instrumenters API that we currently use to collect instrumentation, in favor of Telemetry events: https://hexdocs.pm/phoenix/Phoenix.Endpoint.html#module-instrumentation

We should probably add some simple adapter functions to SpandexPhoenix.Instrumenter so that it will be an easy conversion to delegate to that module for either instrumenters or Telemetry events.
@egze
Copy link

egze commented May 11, 2020

Hi. Phoenix 1.5 is here.

Now it produces this warning:
12:22:30.755 [warn] :instrumenters configuration for Web.Endpoint is deprecated and has no effect

Is there any quick fix for this?

@InoMurko InoMurko mentioned this issue May 20, 2020
Closed
@novaugust
Copy link
Contributor

@GregMefford I have a day or two of OSS time built up, I'll see if I can spike something up for this

@novaugust novaugust mentioned this issue May 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat!: Add Phx 1.5 Telemetry Handlers novaugust/spandex_phoenix
3 participants
@egze @GregMefford @novaugust