kSecAttrProtocol meaningless on generic password

[bdenckla-ua]

Setting (or querying) the kSecAttrProtocol property of a generic password is not meaningful, AFAICT.

AFAICT it is only meaningful for an Internet password, which Sparkle does not use.

Therefore, the 3 instances of setting or querying for kSecAttrProtocol with value kSecAttrProtocolSSH don't seem to be wrong, per se, but sure are misleading!

https://github.com/sparkle-project/Sparkle/search?q=kSecAttrProtocol&unscoped_q=kSecAttrProtocol

[kornelski]

macOS doesn't support EdDSA keys "natively" as key storage, so I've had to shove it into a password, and make it seem as much like a key as possible.

I couldn't find good docs about meaning and applicability of all these properties, so it's likely that not all of them are needed.